1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
|
__revision__ = '$Revision$'
__all__ = ['Bundles',
'Comments',
'Duplicates',
'InfoXML',
'Pkgmgr',
'RequiredAttrs',
'Validate']
import logging
import os.path
from copy import copy
import lxml.etree
import Bcfg2.Logger
def returnErrors(fn):
""" Decorator for Run method that returns error counts """
return fn
class Plugin (object):
""" base class for ServerlessPlugin and ServerPlugin """
def __init__(self, config, errorhandler=None, files=None):
self.files = files
self.config = config
self.logger = logging.getLogger('bcfg2-lint')
if errorhandler is None:
self.errorHandler = ErrorHandler()
else:
self.errorHandler = errorhandler
def Run(self):
""" run the plugin. must be overloaded by child classes """
pass
def HandlesFile(self, fname):
""" returns true if the given file should be handled by the
plugin according to the files list, false otherwise """
return (self.files is None or
fname in self.files or
os.path.join(self.config['repo'], fname) in self.files or
os.path.abspath(fname) in self.files or
os.path.abspath(os.path.join(self.config['repo'],
fname)) in self.files)
def LintError(self, err, msg):
self.errorHandler.dispatch(err, msg)
def RenderXML(self, element):
"""render an XML element for error output -- line number
prefixed, no children"""
xml = None
if len(element) or element.text:
el = copy(element)
if el.text:
el.text = '...'
[el.remove(c) for c in el.iterchildren()]
xml = lxml.etree.tostring(el).strip()
else:
xml = lxml.etree.tostring(element).strip()
return " line %s: %s" % (element.sourceline, xml)
class ErrorHandler (object):
# how to handle different errors by default
_errors = {"no-infoxml":"warning",
"paranoid-false":"warning",
"bundle-not-found":"error",
"inconsistent-bundle-name":"warning",
"group-tag-not-allowed":"error",
"unexpanded-keywords":"warning",
"keywords-not-found":"warning",
"comments-not-found":"warning",
"broken-xinclude-chain":"warning",
"duplicate-client":"error",
"duplicate-group":"error",
"duplicate-package":"error",
"multiple-default-groups":"error",
"required-infoxml-attrs-missing":"error",
"unknown-path-type":"error",
"required-attrs-missing":"error",
"schema-failed-to-parse":"warning",
"properties-schema-not-found":"warning",
"xml-failed-to-parse":"error",
"xml-failed-to-read":"error",
"xml-failed-to-verify":"error",}
def __init__(self, config=None):
self.errors = 0
self.warnings = 0
self.logger = logging.getLogger('bcfg2-lint')
self._handlers = {}
if config is not None:
for err, action in config.items():
if "warn" in action:
self._handlers[err] = self.warn
elif "err" in action:
self._handlers[err] = self.error
else:
self._handlers[err] = self.debug
for err, action in self._errors.items():
if err not in self._handlers:
if "warn" in action:
self._handlers[err] = self.warn
elif "err" in action:
self._handlers[err] = self.error
else:
self._handlers[err] = self.debug
def dispatch(self, err, msg):
if err in self._handlers:
self._handlers[err](msg)
self.logger.debug(" (%s)" % err)
else:
self.logger.info("Unknown error %s" % err)
def error(self, msg):
""" log an error condition """
self.errors += 1
lines = msg.splitlines()
self.logger.error("ERROR: %s" % lines.pop())
[self.logger.error(" %s" % l) for l in lines]
def warn(self, msg):
""" log a warning condition """
self.warnings += 1
lines = msg.splitlines()
self.logger.warning("WARNING: %s" % lines.pop())
[self.logger.warning(" %s" % l) for l in lines]
def debug(self, msg):
""" log a silent/debug condition """
lines = msg.splitlines()
[self.logger.debug("%s" % l) for l in lines]
class ServerlessPlugin (Plugin):
""" base class for plugins that are run before the server starts
up (i.e., plugins that check things that may prevent the server
from starting up) """
pass
class ServerPlugin (Plugin):
""" base class for plugins that check things that require the
running Bcfg2 server """
def __init__(self, lintCore, config, **kwargs):
Plugin.__init__(self, config, **kwargs)
self.core = lintCore
self.logger = self.core.logger
self.metadata = self.core.metadata
|
