summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJason Rossman <Jason_Rossman@playstation.sony.com>2015-08-27 12:45:47 -0600
committerJason Rossman <Jason_Rossman@playstation.sony.com>2015-08-27 12:45:47 -0600
commit879fa084c9bea87f655dc3025928a251a845980a (patch)
treebedf1c2bf6d21c2efcbc1f023ba892866f32eae5
parent4aafff7f83359531cb2e110f4b7c080e33407cc3 (diff)
downloadchat-879fa084c9bea87f655dc3025928a251a845980a.tar.gz
chat-879fa084c9bea87f655dc3025928a251a845980a.tar.bz2
chat-879fa084c9bea87f655dc3025928a251a845980a.zip
fix GetParentPosts() query
-rw-r--r--api/post_test.go4
-rw-r--r--store/sql_post_store.go4
-rw-r--r--store/sql_post_store_test.go2
3 files changed, 5 insertions, 5 deletions
diff --git a/api/post_test.go b/api/post_test.go
index cbba83af6..af2e4f326 100644
--- a/api/post_test.go
+++ b/api/post_test.go
@@ -331,7 +331,7 @@ func TestGetPosts(t *testing.T) {
t.Fatal("wrong order")
}
- if len(r1.Posts) != 4 {
+ if len(r1.Posts) != 2 { // 3a1 and 3; 3a1's parent already there
t.Fatal("wrong size")
}
@@ -345,7 +345,7 @@ func TestGetPosts(t *testing.T) {
t.Fatal("wrong order")
}
- if len(r2.Posts) != 4 {
+ if len(r2.Posts) != 3 { // 2 and 1a1; + 1a1's parent
t.Log(r2.Posts)
t.Fatal("wrong size")
}
diff --git a/store/sql_post_store.go b/store/sql_post_store.go
index 81405c620..78361270e 100644
--- a/store/sql_post_store.go
+++ b/store/sql_post_store.go
@@ -343,9 +343,9 @@ func (s SqlPostStore) getParentsPosts(channelId string, offset int, limit int) S
WHERE
ChannelId = :ChannelId1
AND DeleteAt = 0
- AND RootId <> ''
ORDER BY CreateAt DESC
- LIMIT :Limit OFFSET :Offset) q3) q1 ON q1.RootId = q2.RootId
+ LIMIT :Limit OFFSET :Offset) q3
+ WHERE q3.RootId != '') q1 ON q1.RootId = q2.Id
WHERE
ChannelId = :ChannelId2
AND DeleteAt = 0
diff --git a/store/sql_post_store_test.go b/store/sql_post_store_test.go
index 336a20d98..5855607fd 100644
--- a/store/sql_post_store_test.go
+++ b/store/sql_post_store_test.go
@@ -374,7 +374,7 @@ func TestPostStoreGetPostsWtihDetails(t *testing.T) {
t.Fatal("invalid order")
}
- if len(r1.Posts) != 6 {
+ if len(r1.Posts) != 5 { //the last 4, + o1 (o3 and o2a's parent)
t.Fatal("wrong size")
}