diff options
author | Harrison Healey <harrisonmhealey@gmail.com> | 2016-06-27 08:21:24 -0400 |
---|---|---|
committer | Christopher Speller <crspeller@gmail.com> | 2016-06-27 08:21:24 -0400 |
commit | b9cf09b5a40e590cdc13ca54558fe5431835df50 (patch) | |
tree | 2d08adbc866f9a8d3a008bfc9c86faca60ac9f2b | |
parent | 459eee85a9ef4ee484565c089a8fc4e151fccc8a (diff) | |
download | chat-b9cf09b5a40e590cdc13ca54558fe5431835df50.tar.gz chat-b9cf09b5a40e590cdc13ca54558fe5431835df50.tar.bz2 chat-b9cf09b5a40e590cdc13ca54558fe5431835df50.zip |
PLT-3242 Fixed clicking on input labels on iOS (#3417)
* Prevented channel notification settings radiobuttons from multi-selecting
* Fixed clicking on input labels on iOS
-rw-r--r-- | webapp/components/channel_notifications_modal.jsx | 6 | ||||
-rw-r--r-- | webapp/sass/responsive/_mobile.scss | 6 |
2 files changed, 12 insertions, 0 deletions
diff --git a/webapp/components/channel_notifications_modal.jsx b/webapp/components/channel_notifications_modal.jsx index 74ec2376b..e6430402a 100644 --- a/webapp/components/channel_notifications_modal.jsx +++ b/webapp/components/channel_notifications_modal.jsx @@ -132,6 +132,7 @@ export default class ChannelNotificationsModal extends React.Component { <label> <input type='radio' + name='desktopNotificationLevel' checked={notifyActive[0]} onChange={this.handleUpdateNotifyLevel.bind(this, 'default')} /> @@ -149,6 +150,7 @@ export default class ChannelNotificationsModal extends React.Component { <label> <input type='radio' + name='desktopNotificationLevel' checked={notifyActive[1]} onChange={this.handleUpdateNotifyLevel.bind(this, 'all')} /> @@ -160,6 +162,7 @@ export default class ChannelNotificationsModal extends React.Component { <label> <input type='radio' + name='desktopNotificationLevel' checked={notifyActive[2]} onChange={this.handleUpdateNotifyLevel.bind(this, 'mention')} /> @@ -171,6 +174,7 @@ export default class ChannelNotificationsModal extends React.Component { <label> <input type='radio' + name='desktopNotificationLevel' checked={notifyActive[3]} onChange={this.handleUpdateNotifyLevel.bind(this, 'none')} /> @@ -285,6 +289,7 @@ export default class ChannelNotificationsModal extends React.Component { <label> <input type='radio' + name='markUnreadLevel' checked={this.state.unreadLevel === 'all'} onChange={this.handleUpdateMarkUnreadLevel.bind(this, 'all')} /> @@ -299,6 +304,7 @@ export default class ChannelNotificationsModal extends React.Component { <label> <input type='radio' + name='markUnreadLevel' checked={this.state.unreadLevel === 'mention'} onChange={this.handleUpdateMarkUnreadLevel.bind(this, 'mention')} /> diff --git a/webapp/sass/responsive/_mobile.scss b/webapp/sass/responsive/_mobile.scss index 6308829ec..78bd8580d 100644 --- a/webapp/sass/responsive/_mobile.scss +++ b/webapp/sass/responsive/_mobile.scss @@ -1051,3 +1051,9 @@ } } } + +// on iOS, allow clicks within an input's label to actually propagate through to the input itself +// http://stackoverflow.com/a/34810294/6325807 +label span { + pointer-events: none; +}
\ No newline at end of file |