summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJoram Wilander <jwawilander@gmail.com>2016-07-05 11:20:48 -0400
committerHarrison Healey <harrisonmhealey@gmail.com>2016-07-05 11:20:48 -0400
commitc0392a60c8a0b6158255b516f30eb79e43971b6b (patch)
tree5739c959446472f7bcdee3450dd72d9176c279fe
parent0f873c01da5d6b86f6cdb7f809f006732b302dfd (diff)
downloadchat-c0392a60c8a0b6158255b516f30eb79e43971b6b.tar.gz
chat-c0392a60c8a0b6158255b516f30eb79e43971b6b.tar.bz2
chat-c0392a60c8a0b6158255b516f30eb79e43971b6b.zip
Fix RHS adding an unecessary preference store listener and increase preference store listener max to 25 (#3473)
-rw-r--r--webapp/components/rhs_thread.jsx3
-rw-r--r--webapp/stores/preference_store.jsx1
2 files changed, 2 insertions, 2 deletions
diff --git a/webapp/components/rhs_thread.jsx b/webapp/components/rhs_thread.jsx
index 9922e3e1f..9e2ecd159 100644
--- a/webapp/components/rhs_thread.jsx
+++ b/webapp/components/rhs_thread.jsx
@@ -65,7 +65,6 @@ export default class RhsThread extends React.Component {
componentDidMount() {
PostStore.addSelectedPostChangeListener(this.onPostChange);
PostStore.addChangeListener(this.onPostChange);
- PreferenceStore.addChangeListener(this.forceUpdateInfo);
PreferenceStore.addChangeListener(this.onPreferenceChange);
UserStore.addChangeListener(this.onUserChange);
@@ -77,7 +76,6 @@ export default class RhsThread extends React.Component {
componentWillUnmount() {
PostStore.removeSelectedPostChangeListener(this.onPostChange);
PostStore.removeChangeListener(this.onPostChange);
- PreferenceStore.removeChangeListener(this.forceUpdateInfo);
PreferenceStore.removeChangeListener(this.onPreferenceChange);
UserStore.removeChangeListener(this.onUserChange);
@@ -141,6 +139,7 @@ export default class RhsThread extends React.Component {
this.setState({
compactDisplay: PreferenceStore.get(Preferences.CATEGORY_DISPLAY_SETTINGS, Preferences.MESSAGE_DISPLAY, Preferences.MESSAGE_DISPLAY_DEFAULT) === Preferences.MESSAGE_DISPLAY_COMPACT
});
+ this.forceUpdateInfo();
}
onPostChange() {
if (this.mounted) {
diff --git a/webapp/stores/preference_store.jsx b/webapp/stores/preference_store.jsx
index 1e024e60b..324ec4864 100644
--- a/webapp/stores/preference_store.jsx
+++ b/webapp/stores/preference_store.jsx
@@ -113,5 +113,6 @@ class PreferenceStoreClass extends EventEmitter {
}
const PreferenceStore = new PreferenceStoreClass();
+PreferenceStore.setMaxListeners(25);
export default PreferenceStore;
global.window.PreferenceStore = PreferenceStore;