diff options
author | Chris <ccbrown112@gmail.com> | 2018-02-01 20:31:49 -0600 |
---|---|---|
committer | Christopher Speller <crspeller@gmail.com> | 2018-02-01 18:31:49 -0800 |
commit | 0cd2895456f953ef871e10421361578b6c8d4add (patch) | |
tree | bcb900b1cd370b2a732b53f12c829313a0c252d0 | |
parent | 5d7ae48841d7004c16ec516ec9f86312b9c6cae9 (diff) | |
download | chat-0cd2895456f953ef871e10421361578b6c8d4add.tar.gz chat-0cd2895456f953ef871e10421361578b6c8d4add.tar.bz2 chat-0cd2895456f953ef871e10421361578b6c8d4add.zip |
fix image url replacement for blank urls (#8184)
-rw-r--r-- | app/post.go | 2 | ||||
-rw-r--r-- | app/post_test.go | 6 |
2 files changed, 7 insertions, 1 deletions
diff --git a/app/post.go b/app/post.go index bf4725e77..6890d1dd9 100644 --- a/app/post.go +++ b/app/post.go @@ -890,7 +890,7 @@ func (a *App) ImageProxyAdder() func(string) string { } return func(url string) string { - if strings.HasPrefix(url, proxyURL) { + if url == "" || strings.HasPrefix(url, proxyURL) { return url } diff --git a/app/post_test.go b/app/post_test.go index 9854bb707..3f3783265 100644 --- a/app/post_test.go +++ b/app/post_test.go @@ -211,6 +211,12 @@ func TestImageProxy(t *testing.T) { ImageURL: "http://mydomain.com/myimage", ProxiedImageURL: "https://127.0.0.1/x1000/http://mydomain.com/myimage", }, + "willnorris/imageproxy_EmptyImageURL": { + ProxyType: "willnorris/imageproxy", + ProxyURL: "https://127.0.0.1", + ImageURL: "", + ProxiedImageURL: "", + }, "willnorris/imageproxy_WithSigning": { ProxyType: "willnorris/imageproxy", ProxyURL: "https://127.0.0.1", |