diff options
author | hmhealey <harrisonmhealey@gmail.com> | 2015-10-07 10:19:02 -0400 |
---|---|---|
committer | hmhealey <harrisonmhealey@gmail.com> | 2015-10-13 09:42:26 -0400 |
commit | a6cd2a79612d6d96e0e929ab769ec5e70cd35f5f (patch) | |
tree | 0a063e8b2e4da202292e2b2fded440c1777b6e55 /api/preference.go | |
parent | 5832232b6d3d79023204d357b0de33eff9e00370 (diff) | |
download | chat-a6cd2a79612d6d96e0e929ab769ec5e70cd35f5f.tar.gz chat-a6cd2a79612d6d96e0e929ab769ec5e70cd35f5f.tar.bz2 chat-a6cd2a79612d6d96e0e929ab769ec5e70cd35f5f.zip |
Moved saving multiple user preferences into a database transaction
Diffstat (limited to 'api/preference.go')
-rw-r--r-- | api/preference.go | 14 |
1 files changed, 5 insertions, 9 deletions
diff --git a/api/preference.go b/api/preference.go index 84cfc130c..810917a7c 100644 --- a/api/preference.go +++ b/api/preference.go @@ -20,7 +20,7 @@ func InitPreference(r *mux.Router) { } func setPreferences(c *Context, w http.ResponseWriter, r *http.Request) { - var preferences []model.Preference + var preferences []*model.Preference decoder := json.NewDecoder(r.Body) if err := decoder.Decode(&preferences); err != nil { @@ -29,21 +29,17 @@ func setPreferences(c *Context, w http.ResponseWriter, r *http.Request) { return } - // just attempt to save/update them one by one and abort if one fails - // in the future, this could probably be done in a transaction, but that's unnecessary now for _, preference := range preferences { if c.Session.UserId != preference.UserId { c.Err = model.NewAppError("setPreferences", "Unable to set preferences for other user", "session.user_id="+c.Session.UserId+", preference.user_id="+preference.UserId) c.Err.StatusCode = http.StatusUnauthorized return } + } - if result := <-Srv.Store.Preference().Save(&preference); result.Err != nil { - if result = <-Srv.Store.Preference().Update(&preference); result.Err != nil { - c.Err = result.Err - return - } - } + if result := <-Srv.Store.Preference().SaveOrUpdate(preferences...); result.Err != nil { + c.Err = result.Err + return } w.Write([]byte("true")) |