diff options
| author | George Goldberg <george@gberg.me> | 2018-03-26 12:56:57 +0100 |
|---|---|---|
| committer | Jesús Espino <jespinog@gmail.com> | 2018-03-26 13:56:57 +0200 |
| commit | ca5198c7b64f76027bf7b7cc4592c62b42fee623 (patch) | |
| tree | a6affcee7dbcca7f7996d1dedf4d1aef2ba78b7c /api4/role_test.go | |
| parent | 5fa1b3581955761bd39c310bc88b1489d963a9fc (diff) | |
| download | chat-ca5198c7b64f76027bf7b7cc4592c62b42fee623.tar.gz chat-ca5198c7b64f76027bf7b7cc4592c62b42fee623.tar.bz2 chat-ca5198c7b64f76027bf7b7cc4592c62b42fee623.zip | |
Ignore blank role names in getRolesByName call. (#8507)
Diffstat (limited to 'api4/role_test.go')
| -rw-r--r-- | api4/role_test.go | 12 |
1 files changed, 10 insertions, 2 deletions
diff --git a/api4/role_test.go b/api4/role_test.go index 3fbf6808d..c5d8e303e 100644 --- a/api4/role_test.go +++ b/api4/role_test.go @@ -129,13 +129,21 @@ func TestGetRolesByNames(t *testing.T) { assert.Contains(t, received, role2) assert.Contains(t, received, role3) - // Check a list of invalid roles. - // TODO: Confirm whether no error for invalid role names is intended. + // Check a list of non-existant roles. received, resp = th.Client.GetRolesByNames([]string{model.NewId(), model.NewId()}) CheckNoError(t, resp) + // Empty list should error. _, resp = th.SystemAdminClient.GetRolesByNames([]string{}) CheckBadRequestStatus(t, resp) + + // Invalid role name should error. + received, resp = th.Client.GetRolesByNames([]string{model.NewId(), model.NewId(), "!!!!!!"}) + CheckBadRequestStatus(t, resp) + + // Empty/whitespace rolenames should be ignored. + received, resp = th.Client.GetRolesByNames([]string{model.NewId(), model.NewId(), "", " "}) + CheckNoError(t, resp) } func TestPatchRole(t *testing.T) { |