diff options
author | Joram Wilander <jwawilander@gmail.com> | 2017-08-15 16:25:36 -0400 |
---|---|---|
committer | Saturnino Abril <saturnino.abril@gmail.com> | 2017-08-16 04:25:36 +0800 |
commit | 0033e3e37b12cb5d951d21492500d66a6abc472b (patch) | |
tree | cc8e1f306436fa48807810d184c5a8a1962c792a /api4/webhook.go | |
parent | 7d3719b5c67327da42822071e001b38f0a3f8db7 (diff) | |
download | chat-0033e3e37b12cb5d951d21492500d66a6abc472b.tar.gz chat-0033e3e37b12cb5d951d21492500d66a6abc472b.tar.bz2 chat-0033e3e37b12cb5d951d21492500d66a6abc472b.zip |
PLT-7408 Move webhook handling into api4 package to fix EnableAPIv3 config setting (#7219)
* Move webhook handling into api4 package to fix EnableAPIv3 config setting
* Fix unit test
Diffstat (limited to 'api4/webhook.go')
-rw-r--r-- | api4/webhook.go | 51 |
1 files changed, 51 insertions, 0 deletions
diff --git a/api4/webhook.go b/api4/webhook.go index 668636932..ef68fd9fe 100644 --- a/api4/webhook.go +++ b/api4/webhook.go @@ -4,9 +4,12 @@ package api4 import ( + "io" "net/http" + "strings" l4g "github.com/alecthomas/log4go" + "github.com/gorilla/mux" "github.com/mattermost/platform/app" "github.com/mattermost/platform/model" "github.com/mattermost/platform/utils" @@ -27,6 +30,11 @@ func InitWebhook() { BaseRoutes.OutgoingHook.Handle("", ApiSessionRequired(updateOutgoingHook)).Methods("PUT") BaseRoutes.OutgoingHook.Handle("", ApiSessionRequired(deleteOutgoingHook)).Methods("DELETE") BaseRoutes.OutgoingHook.Handle("/regen_token", ApiSessionRequired(regenOutgoingHookToken)).Methods("POST") + + BaseRoutes.Root.Handle("/hooks/{id:[A-Za-z0-9]+}", ApiHandler(incomingWebhook)).Methods("POST") + + // Old endpoint for backwards compatibility + BaseRoutes.Root.Handle("/api/v3/teams/{team_id:[A-Za-z0-9]+}/hooks/{id:[A-Za-z0-9]+}", ApiHandler(incomingWebhook)).Methods("POST") } func createIncomingHook(c *Context, w http.ResponseWriter, r *http.Request) { @@ -435,3 +443,46 @@ func deleteOutgoingHook(c *Context, w http.ResponseWriter, r *http.Request) { c.LogAudit("success") ReturnStatusOK(w) } + +func incomingWebhook(c *Context, w http.ResponseWriter, r *http.Request) { + params := mux.Vars(r) + id := params["id"] + + r.ParseForm() + + var payload io.Reader + contentType := r.Header.Get("Content-Type") + if strings.Split(contentType, "; ")[0] == "application/x-www-form-urlencoded" { + payload = strings.NewReader(r.FormValue("payload")) + } else { + payload = r.Body + } + + if utils.Cfg.LogSettings.EnableWebhookDebugging { + var err error + payload, err = utils.DebugReader( + payload, + utils.T("api.webhook.incoming.debug"), + ) + if err != nil { + c.Err = model.NewLocAppError( + "incomingWebhook", + "api.webhook.incoming.debug.error", + nil, + err.Error(), + ) + return + } + } + + parsedRequest := model.IncomingWebhookRequestFromJson(payload) + + err := app.HandleIncomingWebhook(id, parsedRequest) + if err != nil { + c.Err = err + return + } + + w.Header().Set("Content-Type", "text/plain") + w.Write([]byte("ok")) +} |