diff options
author | Jesús Espino <jespinog@gmail.com> | 2018-10-02 19:33:52 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2018-10-02 19:33:52 +0200 |
commit | 2945e8a2b0ce9306bb049e65eb2410038e0fa18c (patch) | |
tree | cee7c4edc0a947496caec9bf9e6b84b09231d926 /app/channel_test.go | |
parent | c82a84ed765bd9c4d601b93201d93af92f6ee742 (diff) | |
download | chat-2945e8a2b0ce9306bb049e65eb2410038e0fa18c.tar.gz chat-2945e8a2b0ce9306bb049e65eb2410038e0fa18c.tar.bz2 chat-2945e8a2b0ce9306bb049e65eb2410038e0fa18c.zip |
MM-10699: Disallow renaming direct and group message channels (#9518)
* MM-10699: Disallow renaming direct and group message channels
* Replacing errors.New with errors.Wrapf
Diffstat (limited to 'app/channel_test.go')
-rw-r--r-- | app/channel_test.go | 47 |
1 files changed, 40 insertions, 7 deletions
diff --git a/app/channel_test.go b/app/channel_test.go index 4dc8dce37..0501b9406 100644 --- a/app/channel_test.go +++ b/app/channel_test.go @@ -640,12 +640,45 @@ func TestRenameChannel(t *testing.T) { th := Setup().InitBasic() defer th.TearDown() - channel := th.createChannel(th.BasicTeam, model.CHANNEL_OPEN) - - channel, err := th.App.RenameChannel(channel, "newchannelname", "New Display Name") - if err != nil { - t.Fatal("Failed to update channel name. Error: " + err.Error()) + testCases := []struct { + Name string + Channel *model.Channel + ExpectError bool + ExpectedName string + ExpectedDisplayName string + }{ + { + "Rename open channel", + th.createChannel(th.BasicTeam, model.CHANNEL_OPEN), + false, + "newchannelname", + "New Display Name", + }, + { + "Fail on rename direct message channel", + th.CreateDmChannel(th.BasicUser2), + true, + "", + "", + }, + { + "Fail on rename direct message channel", + th.CreateGroupChannel(th.BasicUser2, th.CreateUser()), + true, + "", + "", + }, + } + + for _, tc := range testCases { + t.Run(tc.Name, func(t *testing.T) { + channel, err := th.App.RenameChannel(tc.Channel, "newchannelname", "New Display Name") + if tc.ExpectError { + assert.NotNil(t, err) + } else { + assert.Equal(t, tc.ExpectedName, channel.Name) + assert.Equal(t, tc.ExpectedDisplayName, channel.DisplayName) + } + }) } - assert.Equal(t, "newchannelname", channel.Name) - assert.Equal(t, "New Display Name", channel.DisplayName) } |