diff options
| author | Jesse Hallam <jesse.hallam@gmail.com> | 2018-05-10 18:16:33 -0400 |
|---|---|---|
| committer | Christopher Speller <crspeller@gmail.com> | 2018-05-10 15:16:33 -0700 |
| commit | 2b27e12445ba51e1fa1ab2aceac5fcb3de66845d (patch) | |
| tree | 3d3bf61a39534e8db4cffde9b9644c3ce895580c /app/emoji.go | |
| parent | 7fa1c6c4bae19d1647d759198126ee4591282079 (diff) | |
| download | chat-2b27e12445ba51e1fa1ab2aceac5fcb3de66845d.tar.gz chat-2b27e12445ba51e1fa1ab2aceac5fcb3de66845d.tar.bz2 chat-2b27e12445ba51e1fa1ab2aceac5fcb3de66845d.zip | |
MM-10188: expect io.Reader in FileBackend.WriteFile (#8765)
This is a reworked set of changes originally from @josephGuo to begin
reducing the duplicated memory required when uploading files.
Diffstat (limited to 'app/emoji.go')
| -rw-r--r-- | app/emoji.go | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/app/emoji.go b/app/emoji.go index 2f957fbcc..b07331e65 100644 --- a/app/emoji.go +++ b/app/emoji.go @@ -98,7 +98,7 @@ func (a *App) UploadEmojiImage(id string, imageData *multipart.FileHeader) *mode if err := gif.EncodeAll(newbuf, resized_gif); err != nil { return model.NewAppError("uploadEmojiImage", "api.emoji.upload.large_image.gif_encode_error", nil, "", http.StatusBadRequest) } - if err := a.WriteFile(newbuf.Bytes(), getEmojiImagePath(id)); err != nil { + if _, err := a.WriteFile(newbuf, getEmojiImagePath(id)); err != nil { return err } } @@ -110,14 +110,15 @@ func (a *App) UploadEmojiImage(id string, imageData *multipart.FileHeader) *mode if err := png.Encode(newbuf, resized_image); err != nil { return model.NewAppError("uploadEmojiImage", "api.emoji.upload.large_image.encode_error", nil, "", http.StatusBadRequest) } - if err := a.WriteFile(newbuf.Bytes(), getEmojiImagePath(id)); err != nil { + if _, err := a.WriteFile(newbuf, getEmojiImagePath(id)); err != nil { return err } } } } - return a.WriteFile(buf.Bytes(), getEmojiImagePath(id)) + _, appErr := a.WriteFile(buf, getEmojiImagePath(id)) + return appErr } func (a *App) DeleteEmoji(emoji *model.Emoji) *model.AppError { |