summaryrefslogtreecommitdiffstats
path: root/app/import.go
diff options
context:
space:
mode:
authorJoram Wilander <jwawilander@gmail.com>2018-07-12 16:28:04 -0400
committerGitHub <noreply@github.com>2018-07-12 16:28:04 -0400
commit5ddb08dcb47f938c9ac3a3e6338d9b3cc61c20a7 (patch)
tree4f474492f8b5e13ee37cf76be70c8ec234ce09a2 /app/import.go
parentadc56ae78df2a84c14c5e2921ec9cb14817a2474 (diff)
downloadchat-5ddb08dcb47f938c9ac3a3e6338d9b3cc61c20a7.tar.gz
chat-5ddb08dcb47f938c9ac3a3e6338d9b3cc61c20a7.tar.bz2
chat-5ddb08dcb47f938c9ac3a3e6338d9b3cc61c20a7.zip
Avoid using app function so bulk loading does not fail when custom emojis are disabled (#9064)
Diffstat (limited to 'app/import.go')
-rw-r--r--app/import.go12
1 files changed, 6 insertions, 6 deletions
diff --git a/app/import.go b/app/import.go
index 12353d562..37bef01e7 100644
--- a/app/import.go
+++ b/app/import.go
@@ -1948,11 +1948,11 @@ func (a *App) ImportEmoji(data *EmojiImportData, dryRun bool) *model.AppError {
}
var emoji *model.Emoji
- var err *model.AppError
- emoji, err = a.GetEmojiByName(*data.Name)
- if err != nil && err.StatusCode != http.StatusNotFound {
- return err
+ if result := <-a.Srv.Store.Emoji().GetByName(*data.Name); result.Err != nil && result.Err.StatusCode != http.StatusNotFound {
+ return result.Err
+ } else if result.Data != nil {
+ emoji = result.Data.(*model.Emoji)
}
alreadyExists := emoji != nil
@@ -1964,8 +1964,8 @@ func (a *App) ImportEmoji(data *EmojiImportData, dryRun bool) *model.AppError {
emoji.PreSave()
}
- file, fileErr := os.Open(*data.Image)
- if fileErr != nil {
+ file, err := os.Open(*data.Image)
+ if err != nil {
return model.NewAppError("BulkImport", "app.import.emoji.bad_file.error", map[string]interface{}{"EmojiName": *data.Name}, "", http.StatusBadRequest)
}