diff options
| author | Jesús Espino <jespinog@gmail.com> | 2018-09-28 16:55:14 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-09-28 16:55:14 +0200 |
| commit | a551b375fa6bed975e8df88bf5d024df957a7684 (patch) | |
| tree | 7170a88a044fa5b346af2f83396bb43b50e6fa4e /app/job.go | |
| parent | ee672a72e4c534f2d5f36cc563084279ba31ba87 (diff) | |
| download | chat-a551b375fa6bed975e8df88bf5d024df957a7684.tar.gz chat-a551b375fa6bed975e8df88bf5d024df957a7684.tar.bz2 chat-a551b375fa6bed975e8df88bf5d024df957a7684.zip | |
Idiomatic error handling for app/{job,license,login}.go (#9474)
Diffstat (limited to 'app/job.go')
| -rw-r--r-- | app/job.go | 18 |
1 files changed, 9 insertions, 9 deletions
diff --git a/app/job.go b/app/job.go index d80fe6262..782301de4 100644 --- a/app/job.go +++ b/app/job.go @@ -8,11 +8,11 @@ import ( ) func (a *App) GetJob(id string) (*model.Job, *model.AppError) { - if result := <-a.Srv.Store.Job().Get(id); result.Err != nil { + result := <-a.Srv.Store.Job().Get(id) + if result.Err != nil { return nil, result.Err - } else { - return result.Data.(*model.Job), nil } + return result.Data.(*model.Job), nil } func (a *App) GetJobsPage(page int, perPage int) ([]*model.Job, *model.AppError) { @@ -20,11 +20,11 @@ func (a *App) GetJobsPage(page int, perPage int) ([]*model.Job, *model.AppError) } func (a *App) GetJobs(offset int, limit int) ([]*model.Job, *model.AppError) { - if result := <-a.Srv.Store.Job().GetAllPage(offset, limit); result.Err != nil { + result := <-a.Srv.Store.Job().GetAllPage(offset, limit) + if result.Err != nil { return nil, result.Err - } else { - return result.Data.([]*model.Job), nil } + return result.Data.([]*model.Job), nil } func (a *App) GetJobsByTypePage(jobType string, page int, perPage int) ([]*model.Job, *model.AppError) { @@ -32,11 +32,11 @@ func (a *App) GetJobsByTypePage(jobType string, page int, perPage int) ([]*model } func (a *App) GetJobsByType(jobType string, offset int, limit int) ([]*model.Job, *model.AppError) { - if result := <-a.Srv.Store.Job().GetAllByTypePage(jobType, offset, limit); result.Err != nil { + result := <-a.Srv.Store.Job().GetAllByTypePage(jobType, offset, limit) + if result.Err != nil { return nil, result.Err - } else { - return result.Data.([]*model.Job), nil } + return result.Data.([]*model.Job), nil } func (a *App) CreateJob(job *model.Job) (*model.Job, *model.AppError) { |