diff options
| author | Harrison Healey <harrisonmhealey@gmail.com> | 2018-02-09 10:05:23 -0500 |
|---|---|---|
| committer | Harrison Healey <harrisonmhealey@gmail.com> | 2018-02-09 10:05:23 -0500 |
| commit | e2b5f9217f55074e4a64c90f4121803cd68f0b97 (patch) | |
| tree | c592d1212d24086bfaa9f9b5cd78fd6a6d53ef02 /app/post_test.go | |
| parent | d3a0e561c265e32a305cd5c6ed5e80f461d9f4eb (diff) | |
| download | chat-e2b5f9217f55074e4a64c90f4121803cd68f0b97.tar.gz chat-e2b5f9217f55074e4a64c90f4121803cd68f0b97.tar.bz2 chat-e2b5f9217f55074e4a64c90f4121803cd68f0b97.zip | |
ICU-669 Handle relative links better
Diffstat (limited to 'app/post_test.go')
| -rw-r--r-- | app/post_test.go | 18 |
1 files changed, 15 insertions, 3 deletions
diff --git a/app/post_test.go b/app/post_test.go index 987879a72..62098c865 100644 --- a/app/post_test.go +++ b/app/post_test.go @@ -271,7 +271,7 @@ func TestMakeOpenGraphURLsAbsolute(t *testing.T) { URL: "https://example.com/apps/mattermost", ImageURL: "https://images.example.com/image.png", }, - "relative URLs": { + "URLs starting with /": { HTML: ` <html> <head> @@ -283,7 +283,7 @@ func TestMakeOpenGraphURLsAbsolute(t *testing.T) { URL: "http://example.com/apps/mattermost", ImageURL: "http://example.com/image.png", }, - "relative URLs with HTTPS": { + "HTTPS URLs starting with /": { HTML: ` <html> <head> @@ -306,6 +306,18 @@ func TestMakeOpenGraphURLsAbsolute(t *testing.T) { URL: "http://example.com/apps/mattermost", ImageURL: "", }, + "relative URLs": { + HTML: ` + <html> + <head> + <meta property="og:url" content="index.html"> + <meta property="og:image" content="../resources/image.png"> + </head> + </html>`, + RequestURL: "http://example.com/content/index.html", + URL: "http://example.com/content/index.html", + ImageURL: "http://example.com/resources/image.png", + }, } { t.Run(name, func(t *testing.T) { og := opengraph.NewOpenGraph() @@ -313,7 +325,7 @@ func TestMakeOpenGraphURLsAbsolute(t *testing.T) { t.Fatal(err) } - og = makeOpenGraphURLsAbsolute(og, tc.RequestURL) + makeOpenGraphURLsAbsolute(og, tc.RequestURL) if og.URL != tc.URL { t.Fatalf("incorrect url, expected %v, got %v", tc.URL, og.URL) |