diff options
| author | Ruzette Tanyag <ruzette@users.noreply.github.com> | 2017-02-14 10:28:08 -0500 |
|---|---|---|
| committer | Harrison Healey <harrisonmhealey@gmail.com> | 2017-02-14 10:28:08 -0500 |
| commit | 28aa7cdbf2357bda51ba740fd4d7af48b36b96b4 (patch) | |
| tree | 0a7daa93b5fa594b113f905506ed6ee6940e789b /app | |
| parent | 9dabd10da975a47155641351bbf61b6fb203b4ca (diff) | |
| download | chat-28aa7cdbf2357bda51ba740fd4d7af48b36b96b4.tar.gz chat-28aa7cdbf2357bda51ba740fd4d7af48b36b96b4.tar.bz2 chat-28aa7cdbf2357bda51ba740fd4d7af48b36b96b4.zip | |
Implement GET channels endpoints for APIv4 (#5363)
* implement get channels endpoints and updated drivers and unittests
* removed channel deletion on tear down, removed manage permission on get channels endpoints, and updated utils to add constant channel length
* added constants for user, team and channel length, updated context to use the model functions
* make sure team name length should be less than the minimum length and revert underscore to team name validity
* changed post test condition from notfound to unauthorized
Diffstat (limited to 'app')
| -rw-r--r-- | app/channel.go | 33 |
1 files changed, 31 insertions, 2 deletions
diff --git a/app/channel.go b/app/channel.go index ab832693f..a95a38327 100644 --- a/app/channel.go +++ b/app/channel.go @@ -543,7 +543,11 @@ func PostUpdateChannelDisplayNameMessage(userId string, channelId string, teamId } func GetChannel(channelId string) (*model.Channel, *model.AppError) { - if result := <-Srv.Store.Channel().Get(channelId, true); result.Err != nil { + if result := <-Srv.Store.Channel().Get(channelId, true); result.Err != nil && result.Err.Id == "store.sql_channel.get.existing.app_error" { + result.Err.StatusCode = http.StatusNotFound + return nil, result.Err + } else if result.Err != nil { + result.Err.StatusCode = http.StatusBadRequest return nil, result.Err } else { return result.Data.(*model.Channel), nil @@ -551,7 +555,32 @@ func GetChannel(channelId string) (*model.Channel, *model.AppError) { } func GetChannelByName(channelName, teamId string) (*model.Channel, *model.AppError) { - if result := <-Srv.Store.Channel().GetByName(teamId, channelName, true); result.Err != nil { + if result := <-Srv.Store.Channel().GetByName(teamId, channelName, true); result.Err != nil && result.Err.Id == "store.sql_channel.get_by_name.missing.app_error" { + result.Err.StatusCode = http.StatusNotFound + return nil, result.Err + } else if result.Err != nil { + result.Err.StatusCode = http.StatusBadRequest + return nil, result.Err + } else { + return result.Data.(*model.Channel), nil + } +} + +func GetChannelByNameForTeamName(channelName, teamName string) (*model.Channel, *model.AppError) { + var team *model.Team + + if result := <-Srv.Store.Team().GetByName(teamName); result.Err != nil { + result.Err.StatusCode = http.StatusNotFound + return nil, result.Err + } else { + team = result.Data.(*model.Team) + } + + if result := <-Srv.Store.Channel().GetByName(team.Id, channelName, true); result.Err != nil && result.Err.Id == "store.sql_channel.get_by_name.missing.app_error" { + result.Err.StatusCode = http.StatusNotFound + return nil, result.Err + } else if result.Err != nil { + result.Err.StatusCode = http.StatusBadRequest return nil, result.Err } else { return result.Data.(*model.Channel), nil |