diff options
author | Carlos Tadeu Panato Junior <ctadeu@gmail.com> | 2017-11-21 00:57:35 +0100 |
---|---|---|
committer | Christopher Speller <crspeller@gmail.com> | 2017-11-20 15:57:35 -0800 |
commit | fdba2d50fd431796e49cef00484de410b7a7a350 (patch) | |
tree | f56c63e6b5f4c194c8390d91e1425e7c78106cd3 /app | |
parent | e2b165cf3ea241dd430cca8145a2dc459110666e (diff) | |
download | chat-fdba2d50fd431796e49cef00484de410b7a7a350.tar.gz chat-fdba2d50fd431796e49cef00484de410b7a7a350.tar.bz2 chat-fdba2d50fd431796e49cef00484de410b7a7a350.zip |
[PLT-840] Add option to outgoing webhooks to reply to the posted message as a comment (#7807)
Diffstat (limited to 'app')
-rw-r--r-- | app/webhook.go | 13 | ||||
-rw-r--r-- | app/webhook_test.go | 4 |
2 files changed, 11 insertions, 6 deletions
diff --git a/app/webhook.go b/app/webhook.go index 5ce56aa88..41a789ead 100644 --- a/app/webhook.go +++ b/app/webhook.go @@ -110,10 +110,15 @@ func (a *App) TriggerWebhook(payload *model.OutgoingWebhookPayload, hook *model. l4g.Error(utils.T("api.post.handle_webhook_events_and_forget.event_post.error"), err.Error()) } else { defer consumeAndClose(resp) + webhookResp := model.OutgoingWebhookResponseFromJson(resp.Body) if webhookResp != nil && webhookResp.Text != nil { - if _, err := a.CreateWebhookPost(hook.CreatorId, channel, *webhookResp.Text, webhookResp.Username, webhookResp.IconURL, webhookResp.Props, webhookResp.Type); err != nil { + postRootId := "" + if webhookResp.ResponseType == model.OUTGOING_HOOK_RESPONSE_TYPE_COMMENT { + postRootId = post.Id + } + if _, err := a.CreateWebhookPost(hook.CreatorId, channel, *webhookResp.Text, webhookResp.Username, webhookResp.IconURL, webhookResp.Props, webhookResp.Type, postRootId); err != nil { l4g.Error(utils.T("api.post.handle_webhook_events_and_forget.create_post.error"), err) } } @@ -203,12 +208,12 @@ func SplitWebhookPost(post *model.Post) ([]*model.Post, *model.AppError) { return splits, nil } -func (a *App) CreateWebhookPost(userId string, channel *model.Channel, text, overrideUsername, overrideIconUrl string, props model.StringInterface, postType string) (*model.Post, *model.AppError) { +func (a *App) CreateWebhookPost(userId string, channel *model.Channel, text, overrideUsername, overrideIconUrl string, props model.StringInterface, postType string, postRootId string) (*model.Post, *model.AppError) { // parse links into Markdown format linkWithTextRegex := regexp.MustCompile(`<([^<\|]+)\|([^>]+)>`) text = linkWithTextRegex.ReplaceAllString(text, "[${2}](${1})") - post := &model.Post{UserId: userId, ChannelId: channel.Id, Message: text, Type: postType} + post := &model.Post{UserId: userId, ChannelId: channel.Id, Message: text, Type: postType, RootId: postRootId} post.AddProp("from_webhook", "true") if strings.HasPrefix(post.Type, model.POST_SYSTEM_MESSAGE_PREFIX) { @@ -600,7 +605,7 @@ func (a *App) HandleIncomingWebhook(hookId string, req *model.IncomingWebhookReq overrideUsername := req.Username overrideIconUrl := req.IconURL - _, err := a.CreateWebhookPost(hook.UserId, channel, text, overrideUsername, overrideIconUrl, req.Props, webhookType) + _, err := a.CreateWebhookPost(hook.UserId, channel, text, overrideUsername, overrideIconUrl, req.Props, webhookType, "") return err } diff --git a/app/webhook_test.go b/app/webhook_test.go index f0cc0610a..9fef6fde3 100644 --- a/app/webhook_test.go +++ b/app/webhook_test.go @@ -38,7 +38,7 @@ func TestCreateWebhookPost(t *testing.T) { Text: "text", }, }, - }, model.POST_SLACK_ATTACHMENT) + }, model.POST_SLACK_ATTACHMENT, "") if err != nil { t.Fatal(err.Error()) } @@ -49,7 +49,7 @@ func TestCreateWebhookPost(t *testing.T) { } } - _, err = th.App.CreateWebhookPost(hook.UserId, th.BasicChannel, "foo", "user", "http://iconurl", nil, model.POST_SYSTEM_GENERIC) + _, err = th.App.CreateWebhookPost(hook.UserId, th.BasicChannel, "foo", "user", "http://iconurl", nil, model.POST_SYSTEM_GENERIC, "") if err == nil { t.Fatal("should have failed - bad post type") } |