diff options
| author | Jesse Hallam <jesse.hallam@gmail.com> | 2018-08-09 05:26:38 -0400 |
|---|---|---|
| committer | Jesús Espino <jespinog@gmail.com> | 2018-08-09 11:26:38 +0200 |
| commit | d8c8a19d355fdd67a984fc696269521919bb58b5 (patch) | |
| tree | cb32477ac9031ae9e742434f7a2455d42e56da65 /model/cluster_message_test.go | |
| parent | 0bbabd137bdbe04653426a1731bd8eb9225e0249 (diff) | |
| download | chat-d8c8a19d355fdd67a984fc696269521919bb58b5.tar.gz chat-d8c8a19d355fdd67a984fc696269521919bb58b5.tar.bz2 chat-d8c8a19d355fdd67a984fc696269521919bb58b5.zip | |
avoid t.Fatal() in tests (#9189)
I've been burned a few times by tests that simply fatal, requiring me to
run another build to learn more about what the mismatch was. Avoid this.
This is part of a long running goal of mine to make testing "better".
Diffstat (limited to 'model/cluster_message_test.go')
| -rw-r--r-- | model/cluster_message_test.go | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/model/cluster_message_test.go b/model/cluster_message_test.go index 38603e577..e9225a5c5 100644 --- a/model/cluster_message_test.go +++ b/model/cluster_message_test.go @@ -6,6 +6,8 @@ package model import ( "strings" "testing" + + "github.com/stretchr/testify/require" ) func TestClusterMessage(t *testing.T) { @@ -17,9 +19,7 @@ func TestClusterMessage(t *testing.T) { json := m.ToJson() result := ClusterMessageFromJson(strings.NewReader(json)) - if result.Data != "hello" { - t.Fatal() - } + require.Equal(t, "hello", result.Data) badresult := ClusterMessageFromJson(strings.NewReader("junk")) if badresult != nil { |