MM-11521/MM-11522 Fix being able to create users with invalid emails through API (#9199)

* MM-11522 Fix being able to create users with invalid emails through API

* Ensure store tests are using valid emails

* Add missing license header

* Remove invalid test case

* Fix TestUpdateOAuthUserAttrs

1 files changed, 13 insertions, 8 deletions

diff --git a/model/user_test.go b/model/user_test.go
index a1953a40d..b3aaad522 100644
--- a/model/user_test.go
+++ b/model/user_test.go
@@ -118,34 +118,39 @@ func TestUserIsValid(t *testing.T) {
 
 	user.Id = NewId()
 	if err := user.IsValid(); !HasExpectedUserIsValidError(err, "create_at", user.Id) {
-		t.Fatal()
+		t.Fatal(err)
 	}
 
 	user.CreateAt = GetMillis()
 	if err := user.IsValid(); !HasExpectedUserIsValidError(err, "update_at", user.Id) {
-		t.Fatal()
+		t.Fatal(err)
 	}
 
 	user.UpdateAt = GetMillis()
 	if err := user.IsValid(); !HasExpectedUserIsValidError(err, "username", user.Id) {
-		t.Fatal()
+		t.Fatal(err)
 	}
 
 	user.Username = NewId() + "^hello#"
 	if err := user.IsValid(); !HasExpectedUserIsValidError(err, "username", user.Id) {
-		t.Fatal()
+		t.Fatal(err)
 	}
 
 	user.Username = NewId()
+	if err := user.IsValid(); !HasExpectedUserIsValidError(err, "email", user.Id) {
+		t.Fatal(err)
+	}
+
 	user.Email = strings.Repeat("01234567890", 20)
-	if err := user.IsValid(); err == nil {
-		t.Fatal()
+	if err := user.IsValid(); !HasExpectedUserIsValidError(err, "email", user.Id) {
+		t.Fatal(err)
 	}
 
-	user.Email = strings.Repeat("a", 128)
+	user.Email = "user@example.com"
+
 	user.Nickname = strings.Repeat("a", 65)
 	if err := user.IsValid(); !HasExpectedUserIsValidError(err, "nickname", user.Id) {
-		t.Fatal()
+		t.Fatal(err)
 	}
 
 	user.Nickname = strings.Repeat("a", 64)