diff options
| author | Joram Wilander <jwawilander@gmail.com> | 2017-12-01 15:20:08 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2017-12-01 15:20:08 -0500 |
| commit | c3af8785734803b6199a28249537ef3e47fe4caa (patch) | |
| tree | 8260b673bf1da0a41bd5a8375b5d28789ebefa7d /model | |
| parent | 739d91f21387448f0071f06675fb71c7625fa46a (diff) | |
| download | chat-c3af8785734803b6199a28249537ef3e47fe4caa.tar.gz chat-c3af8785734803b6199a28249537ef3e47fe4caa.tar.bz2 chat-c3af8785734803b6199a28249537ef3e47fe4caa.zip | |
Hash key for plugin store table and limit plugin ID length (#7915)
* Hash plugin store keys and update column limits
* Limit plugin ID length on install
* Add note to manifest id and allow zero length keys
Diffstat (limited to 'model')
| -rw-r--r-- | model/manifest.go | 5 | ||||
| -rw-r--r-- | model/plugin_key_value.go | 4 |
2 files changed, 5 insertions, 4 deletions
diff --git a/model/manifest.go b/model/manifest.go index 121d3e0d2..7d28f6dc7 100644 --- a/model/manifest.go +++ b/model/manifest.go @@ -102,8 +102,9 @@ type PluginSettingsSchema struct { // help_text: When true, an extra thing will be enabled! // default: false type Manifest struct { - // The id is a globally unique identifier that represents your plugin. Reverse-DNS notation - // using a name you control is a good option. For example, "com.mycompany.myplugin". + // The id is a globally unique identifier that represents your plugin. Ids are limited + // to 200 characters. Reverse-DNS notation using a name you control is a good option. + // For example, "com.mycompany.myplugin". Id string `json:"id" yaml:"id"` // The name to be displayed for the plugin. diff --git a/model/plugin_key_value.go b/model/plugin_key_value.go index ceb216c2a..093422c82 100644 --- a/model/plugin_key_value.go +++ b/model/plugin_key_value.go @@ -9,8 +9,8 @@ import ( ) const ( - KEY_VALUE_PLUGIN_ID_MAX_RUNES = 100 - KEY_VALUE_KEY_MAX_RUNES = 100 + KEY_VALUE_PLUGIN_ID_MAX_RUNES = 200 + KEY_VALUE_KEY_MAX_RUNES = 50 ) type PluginKeyValue struct { |