summaryrefslogtreecommitdiffstats
path: root/utils/mail.go
diff options
context:
space:
mode:
authorChris <ccbrown112@gmail.com>2017-11-21 13:11:04 -0600
committerChristopher Speller <crspeller@gmail.com>2017-11-21 11:11:04 -0800
commita6694058a7dc970ce53904f8ac637f7fd2cd772b (patch)
tree32cf93bdd237aa952fa78584a7affb038d95e33b /utils/mail.go
parent816a30397da6ceff836d8723233dc5cdbda70871 (diff)
downloadchat-a6694058a7dc970ce53904f8ac637f7fd2cd772b.tar.gz
chat-a6694058a7dc970ce53904f8ac637f7fd2cd772b.tar.bz2
chat-a6694058a7dc970ce53904f8ac637f7fd2cd772b.zip
Revert "workaround for go smtp bug (#7620)" (#7866)
This reverts commit 8966452d1183e94fecc373b9d08c65a0573cbbc6.
Diffstat (limited to 'utils/mail.go')
-rw-r--r--utils/mail.go24
1 files changed, 3 insertions, 21 deletions
diff --git a/utils/mail.go b/utils/mail.go
index 6c38bfc20..716708f69 100644
--- a/utils/mail.go
+++ b/utils/mail.go
@@ -7,13 +7,14 @@ import (
"crypto/tls"
"mime"
"net"
- "net/http"
"net/mail"
"net/smtp"
"time"
"gopkg.in/gomail.v2"
+ "net/http"
+
l4g "github.com/alecthomas/log4go"
"github.com/mattermost/html2text"
"github.com/mattermost/mattermost-server/model"
@@ -47,20 +48,6 @@ func connectToSMTPServer(config *model.Config) (net.Conn, *model.AppError) {
return conn, nil
}
-// TODO: Remove once this bug is fixed: https://github.com/golang/go/issues/22166
-type plainAuthOverTLSConn struct {
- smtp.Auth
-}
-
-func PlainAuthOverTLSConn(identity, username, password, host string) smtp.Auth {
- return &plainAuthOverTLSConn{smtp.PlainAuth(identity, username, password, host)}
-}
-
-func (a *plainAuthOverTLSConn) Start(server *smtp.ServerInfo) (string, []byte, error) {
- server.TLS = true
- return a.Auth.Start(server)
-}
-
func newSMTPClient(conn net.Conn, config *model.Config) (*smtp.Client, *model.AppError) {
c, err := smtp.NewClient(conn, config.EmailSettings.SMTPServer+":"+config.EmailSettings.SMTPPort)
if err != nil {
@@ -86,12 +73,7 @@ func newSMTPClient(conn net.Conn, config *model.Config) (*smtp.Client, *model.Ap
}
if *config.EmailSettings.EnableSMTPAuth {
- var auth smtp.Auth
- if _, ok := conn.(*tls.Conn); ok {
- auth = PlainAuthOverTLSConn("", config.EmailSettings.SMTPUsername, config.EmailSettings.SMTPPassword, config.EmailSettings.SMTPServer+":"+config.EmailSettings.SMTPPort)
- } else {
- auth = smtp.PlainAuth("", config.EmailSettings.SMTPUsername, config.EmailSettings.SMTPPassword, config.EmailSettings.SMTPServer+":"+config.EmailSettings.SMTPPort)
- }
+ auth := smtp.PlainAuth("", config.EmailSettings.SMTPUsername, config.EmailSettings.SMTPPassword, config.EmailSettings.SMTPServer+":"+config.EmailSettings.SMTPPort)
if err = c.Auth(auth); err != nil {
return nil, model.NewAppError("SendMail", "utils.mail.new_client.auth.app_error", nil, err.Error(), http.StatusInternalServerError)