summaryrefslogtreecommitdiffstats
path: root/web/react/components/popover_list_members.jsx
diff options
context:
space:
mode:
authorhmhealey <harrisonmhealey@gmail.com>2015-11-13 09:34:50 -0500
committerhmhealey <harrisonmhealey@gmail.com>2015-11-13 10:18:32 -0500
commit43cb220dcdf6b8906f1c5f9640ad7103dcf8a957 (patch)
tree88dd4e3d1979fa029ba5900a4b890fa7521ae6ce /web/react/components/popover_list_members.jsx
parent0baa1bfe94c7ccd4ccfd5d31ae52d5f227a170d6 (diff)
downloadchat-43cb220dcdf6b8906f1c5f9640ad7103dcf8a957.tar.gz
chat-43cb220dcdf6b8906f1c5f9640ad7103dcf8a957.tar.bz2
chat-43cb220dcdf6b8906f1c5f9640ad7103dcf8a957.zip
Made code for the member popover count a bit more robust to hopefully prevent issues involving old data
Diffstat (limited to 'web/react/components/popover_list_members.jsx')
-rw-r--r--web/react/components/popover_list_members.jsx22
1 files changed, 14 insertions, 8 deletions
diff --git a/web/react/components/popover_list_members.jsx b/web/react/components/popover_list_members.jsx
index bd6b6d3bd..102bddcf5 100644
--- a/web/react/components/popover_list_members.jsx
+++ b/web/react/components/popover_list_members.jsx
@@ -69,7 +69,6 @@ export default class PopoverListMembers extends React.Component {
render() {
let popoverHtml = [];
- let countText = '-';
const members = this.props.members;
const teamMembers = UserStore.getProfilesUsernameMap();
const currentUserId = UserStore.getCurrentId();
@@ -148,13 +147,20 @@ export default class PopoverListMembers extends React.Component {
);
}
});
+ }
- const count = this.props.memberCount;
- if (count > 20) {
- countText = '20+';
- } else if (count > 0) {
- countText = count.toString();
- }
+ let count = this.props.memberCount;
+ let countText = '-';
+
+ // fall back to checking the length of the member list if the count isn't set
+ if (!count && members) {
+ count = members.length;
+ }
+
+ if (count > 20) {
+ countText = '20+';
+ } else if (count > 0) {
+ countText = count.toString();
}
return (
@@ -194,6 +200,6 @@ export default class PopoverListMembers extends React.Component {
PopoverListMembers.propTypes = {
members: React.PropTypes.array.isRequired,
- memberCount: React.PropTypes.number.isRequired,
+ memberCount: React.PropTypes.number,
channelId: React.PropTypes.string.isRequired
};