summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--api4/webhook.go30
-rw-r--r--api4/webhook_test.go39
-rw-r--r--model/client4.go10
3 files changed, 79 insertions, 0 deletions
diff --git a/api4/webhook.go b/api4/webhook.go
index aaaf6f396..8d2c4874f 100644
--- a/api4/webhook.go
+++ b/api4/webhook.go
@@ -24,6 +24,7 @@ func InitWebhook() {
BaseRoutes.OutgoingHooks.Handle("", ApiSessionRequired(createOutgoingHook)).Methods("POST")
BaseRoutes.OutgoingHooks.Handle("", ApiSessionRequired(getOutgoingHooks)).Methods("GET")
BaseRoutes.OutgoingHook.Handle("", ApiSessionRequired(updateOutcomingHook)).Methods("PUT")
+ BaseRoutes.OutgoingHook.Handle("", ApiSessionRequired(getOutgoingHook)).Methods("GET")
BaseRoutes.OutgoingHook.Handle("/regen_token", ApiSessionRequired(regenOutgoingHookToken)).Methods("POST")
}
@@ -333,6 +334,35 @@ func getOutgoingHooks(c *Context, w http.ResponseWriter, r *http.Request) {
w.Write([]byte(model.OutgoingWebhookListToJson(hooks)))
}
+func getOutgoingHook(c *Context, w http.ResponseWriter, r *http.Request) {
+ c.RequireHookId()
+ if c.Err != nil {
+ return
+ }
+
+ hook, err := app.GetOutgoingWebhook(c.Params.HookId)
+ if err != nil {
+ c.Err = err
+ return
+ }
+
+ c.LogAudit("attempt")
+
+ if !app.SessionHasPermissionToTeam(c.Session, hook.TeamId, model.PERMISSION_MANAGE_WEBHOOKS) {
+ c.SetPermissionError(model.PERMISSION_MANAGE_WEBHOOKS)
+ return
+ }
+
+ if c.Session.UserId != hook.CreatorId && !app.SessionHasPermissionToTeam(c.Session, hook.TeamId, model.PERMISSION_MANAGE_OTHERS_WEBHOOKS) {
+ c.LogAudit("fail - inappropriate permissions")
+ c.SetPermissionError(model.PERMISSION_MANAGE_OTHERS_WEBHOOKS)
+ return
+ }
+
+ c.LogAudit("success")
+ w.Write([]byte(hook.ToJson()))
+}
+
func regenOutgoingHookToken(c *Context, w http.ResponseWriter, r *http.Request) {
c.RequireHookId()
if c.Err != nil {
diff --git a/api4/webhook_test.go b/api4/webhook_test.go
index 20ff859ac..80b03c5aa 100644
--- a/api4/webhook_test.go
+++ b/api4/webhook_test.go
@@ -419,6 +419,45 @@ func TestGetOutgoingWebhooks(t *testing.T) {
CheckUnauthorizedStatus(t, resp)
}
+func TestGetOutgoingWebhook(t *testing.T) {
+ th := Setup().InitBasic().InitSystemAdmin()
+ defer TearDown()
+ Client := th.Client
+
+ enableOutgoingHooks := utils.Cfg.ServiceSettings.EnableOutgoingWebhooks
+ enableAdminOnlyHooks := utils.Cfg.ServiceSettings.EnableOnlyAdminIntegrations
+ defer func() {
+ utils.Cfg.ServiceSettings.EnableOutgoingWebhooks = enableOutgoingHooks
+ utils.Cfg.ServiceSettings.EnableOnlyAdminIntegrations = enableAdminOnlyHooks
+ utils.SetDefaultRolesBasedOnConfig()
+ }()
+ utils.Cfg.ServiceSettings.EnableOutgoingWebhooks = true
+ *utils.Cfg.ServiceSettings.EnableOnlyAdminIntegrations = true
+ utils.SetDefaultRolesBasedOnConfig()
+
+ hook := &model.OutgoingWebhook{ChannelId: th.BasicChannel.Id, TeamId: th.BasicChannel.TeamId, CallbackURLs: []string{"http://nowhere.com"}}
+
+ rhook, resp := th.SystemAdminClient.CreateOutgoingWebhook(hook)
+ CheckNoError(t, resp)
+
+ getHook, resp := th.SystemAdminClient.GetOutgoingWebhook(rhook.Id)
+ CheckNoError(t, resp)
+ if getHook.Id != rhook.Id {
+ t.Fatal("failed to retrieve the correct outgoing hook")
+ }
+
+ _, resp = Client.GetOutgoingWebhook(rhook.Id)
+ CheckForbiddenStatus(t, resp)
+
+ nonExistentHook := &model.OutgoingWebhook{ChannelId: th.BasicChannel.Id}
+ _, resp = th.SystemAdminClient.GetOutgoingWebhook(nonExistentHook.Id)
+ CheckNotFoundStatus(t, resp)
+
+ nonExistentHook.Id = model.NewId()
+ _, resp = th.SystemAdminClient.GetOutgoingWebhook(nonExistentHook.Id)
+ CheckInternalErrorStatus(t, resp)
+}
+
func TestUpdateIncomingHook(t *testing.T) {
th := Setup().InitBasic().InitSystemAdmin()
defer TearDown()
diff --git a/model/client4.go b/model/client4.go
index 420b8d510..5b7f502e1 100644
--- a/model/client4.go
+++ b/model/client4.go
@@ -1341,6 +1341,16 @@ func (c *Client4) GetOutgoingWebhooks(page int, perPage int, etag string) ([]*Ou
}
}
+// GetOutgoingWebhook outgoing webhooks on the system requested by Hook Id.
+func (c *Client4) GetOutgoingWebhook(hookId string) (*OutgoingWebhook, *Response) {
+ if r, err := c.DoApiGet(c.GetOutgoingWebhookRoute(hookId), ""); err != nil {
+ return nil, &Response{StatusCode: r.StatusCode, Error: err}
+ } else {
+ defer closeBody(r)
+ return OutgoingWebhookFromJson(r.Body), BuildResponse(r)
+ }
+}
+
// GetOutgoingWebhooksForChannel returns a page of outgoing webhooks for a channel. Page counting starts at 0.
func (c *Client4) GetOutgoingWebhooksForChannel(channelId string, page int, perPage int, etag string) ([]*OutgoingWebhook, *Response) {
query := fmt.Sprintf("?page=%v&per_page=%v&channel_id=%v", page, perPage, channelId)