diff options
Diffstat (limited to 'app/notification_test.go')
| -rw-r--r-- | app/notification_test.go | 39 |
1 files changed, 39 insertions, 0 deletions
diff --git a/app/notification_test.go b/app/notification_test.go index 05574eb08..c72610b60 100644 --- a/app/notification_test.go +++ b/app/notification_test.go @@ -344,6 +344,45 @@ func TestGetExplicitMentions(t *testing.T) { ChannelMentioned: true, }, }, + + // The following tests cover cases where the message mentions @user.name, so we shouldn't assume that + // the user might be intending to mention some @user that isn't in the channel. + "Don't include potential mention that's part of an actual mention (without trailing period)": { + Message: "this is an message for @user.name", + Keywords: map[string][]string{"@user.name": {id1}}, + Expected: &ExplicitMentions{ + MentionedUserIds: map[string]bool{ + id1: true, + }, + }, + }, + "Don't include potential mention that's part of an actual mention (with trailing period)": { + Message: "this is an message for @user.name.", + Keywords: map[string][]string{"@user.name": {id1}}, + Expected: &ExplicitMentions{ + MentionedUserIds: map[string]bool{ + id1: true, + }, + }, + }, + "Don't include potential mention that's part of an actual mention (with multiple trailing periods)": { + Message: "this is an message for @user.name...", + Keywords: map[string][]string{"@user.name": {id1}}, + Expected: &ExplicitMentions{ + MentionedUserIds: map[string]bool{ + id1: true, + }, + }, + }, + "Don't include potential mention that's part of an actual mention (containing and followed by multiple periods)": { + Message: "this is an message for @user...name...", + Keywords: map[string][]string{"@user...name": {id1}}, + Expected: &ExplicitMentions{ + MentionedUserIds: map[string]bool{ + id1: true, + }, + }, + }, } { t.Run(name, func(t *testing.T) { m := GetExplicitMentions(tc.Message, tc.Keywords) |