summaryrefslogtreecommitdiffstats
path: root/api
Commit message (Collapse)AuthorAgeFilesLines
* AllowEditPost and PostEditTimeLimit migration (#8208)Jesús Espino2018-02-091-4/+9
| | | | | | | | * AllowEditPost and PostEditTimeLimit migration * Not set EDIT_POST permission to sysadmin_role if ALLOW_EDIT_POST is configured to NEVER * Remove a bit of code duplication
* Merge remote-tracking branch 'origin/master' into advanced-permissions-phase-1Jesús Espino2018-02-073-4/+8
|\
| * Abort on critical error during server startup (#8204)Pierre de La Morinerie2018-02-071-1/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Only a handful of critical errors are present in the codebase. They all occur during server startup (in `app.StartServer()`). Currently, when one of these critical error occurs, it is simpled mentionned in the logs – then the error is discarded, and the app attempts to continue the execution (and probably fails pretty quickly in a weird way). Rather than continuing operations in an unknow state, these errors should trigger a clean exit. This commit rewrites critical startup errors to be correctly propagated, logged, and then terminate the command execution. Additionnaly, it makes the server return a proper error code to the shell.
| * add App.License, remove utils.IsLicensed / utils.License calls (#8203)Chris2018-02-063-5/+4
| |
* | Merge branch 'master' into advanced-permissions-phase-1George Goldberg2018-02-063-37/+55
|\|
| * ABC-179: check email verification last (#8172)Jesse Hallam2018-02-052-5/+42
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * ABC-179: check email verification last This change changes the authentication checks to be: * "preflight checks" ** mfa ** not disabled ** login attempts * password * "postflight checks" ** email verified Checking whether the email is verified or not last avoids the weird edge case where entering any bogus password for an account with an unverified email shows a message about verifying the email and offering to resend. * fix invalid unit test assertion Client.CreateUser returns a user whose password has been sanitized. Adopt the pattern in the previous assertions to use a new variable name and test the password on the original model.User object. This didn't expose any underlying broken behaviour, but the test wouldn't have caught it if it had regressed. Also fix a minor typo.
| * User based rate limiting (#8152)Christopher Speller2018-01-311-32/+13
| |
* | XYZ-37: Advanced Permissions Phase 1 Backend. (#8159)George Goldberg2018-02-067-839/+359
|/ | | | | | | | | | | | | | | | | | | | | | | | | | * XYZ-13: Update Permission and Role structs to new design. * XYZ-10: Role store. * XYZ-9/XYZ-44: Roles API endpoints and WebSocket message. * XYZ-8: Switch server permissions checks to store backed roles. * XYZ-58: Proper validation of roles where required. * XYZ-11/XYZ-55: Migration to store backed roles from policy config. * XYZ-37: Update unit tests to work with database roles. * XYZ-56: Remove the "guest" role. * Changes to SetDefaultRolesFromConfig. * Short-circuit the store if nothing has changed. * Address first round of review comments. * Address second round of review comments.
* PLT-3383: image proxy support (#7991)Chris2018-01-221-1/+1
| | | | | | | | | | | | * image proxy support * go vet fix, remove mistakenly added coverage file * fix test compile error * add validation to config settings and documentation to model functions * add message_source field to post
* Add sort query parameter to GET /emojis (#8121)Joram Wilander2018-01-191-1/+1
|
* Finally remove utils.Cfg (#8113)Chris2018-01-173-26/+35
| | | | | | | | * finally remove utils.Cfg * fix compile error * another test compilation fix
* Allow deactivation of SSO users api3 (#8008)Chris Duarte2018-01-161-1/+9
|
* Remove global config watcher (#8080)Chris2018-01-111-2/+7
| | | | | | | | | | * remove global config watcher * keep config watcher disabled for tests * compile fix * fix resource leak
* [PLT-6936] Translate AppError.Message automatically by default (#8063)Jesús Espino2018-01-081-1/+0
|
* Remove utils.ClientCfg and utils.ClientCfgHash (#8041)Chris2018-01-053-4/+3
| | | | | | * remove utils.ClientCfg and utils.ClientCfgHash * remove unused import
* Reduce logging data races, fix MySQL test race condition (#7994)Chris2017-12-2221-79/+2
| | | | | | | | * fix races * revert unintentional change * fix test as intended
* fix PUT webhook permissions (#7970)Chris2017-12-121-1/+1
|
* origin checker refactor (#7889)Chris2017-11-221-3/+1
|
* HTTP client refactor (#7884)Chris2017-11-221-2/+1
| | | | | | * http client refactor * simplification
* Role refactor (#7867)Chris2017-11-218-116/+101
| | | | | | | | * role refactor * add missing file * fix web test
* refactor template code (#7860)Chris2017-11-202-4/+1
|
* Refactor password validation and config defaults (#7859)Chris2017-11-202-3/+3
| | | | | | * refactor password validation and config defaults * reorder config lines for clarity
* PLT-6217 Fixes system message posted to Town Square when a member leaves a ↵Tsilavina Razafinirina2017-11-201-1/+1
| | | | | | | | | | | | | | | | | | team (#7752) * Fixes system message posted to Town Square when adding/removing team member (#6483) Fixes unit test method call to match RemoveUserFromTeam modification (#6483) Fixes system message posted to Town Square when adding/removing team member (#6483) Removes unnessary error message * Updates system message when a user leaves a team (#6483) * Changes system message when a user is removed from team (#6483) * Adds a new string to be post to town-square when a member is added to a team (#6483)
* Reorganize file util functionality (#7848)Chris2017-11-164-10/+9
| | | | | | | | * reorganize file util functionality * fix api test compilation * fix rebase issue
* PLT-7111 Add groupmsg command (#7419)Jesús Espino2017-11-141-0/+58
| | | | | | | | * Coping command_msg to use as command_groupmsg base * Changing msg to groupmsg names in groumsg command * Add groupmsg command
* more global config ref cleanup (#7802)Chris2017-11-093-4/+3
|
* several one-line panic, race, and logic fixes (#7766)Chris2017-11-032-3/+7
|
* prevent deactivation of sso users (#7759)Chris2017-11-021-1/+1
|
* PLT-7810 Track if an APIv3 endpoint was used in the last day (#7744)Joram Wilander2017-10-311-0/+5
| | | | | | * Track if an APIv3 endpoint was used in the last day * Make it atomic
* [PLT-7362] Add post' root ID to APIv4 addChannelMember to render added user ↵Saturnino Abril2017-10-311-1/+1
| | | | | | | | | | (as system post) at RHS (#7730) * add post' root ID to apiv4 addChannelMember to render added user (as system post) at RHS * add check to post_root_id parameter * add AddChannelMemberWithRootId function for backward compatibility
* PLT-7978 Add websocket event for user role update (#7745)Joram Wilander2017-10-315-8/+8
| | | | | | | | * Add websocket event for user role update * Fix tests * More test fixes
* Refactoring cfg refs and load / save functions (#7749)Chris2017-10-316-24/+14
| | | | | | * refactoring cfg refs and load / save functions * improve error output
* Remove unused variables / code (#7736)Chris2017-10-302-5/+0
| | | | | | * remove unused variables / code * fix bug in testPostStoreGetOldest
* simplify things (#7735)Chris2017-10-303-8/+6
|
* Remove more global refs / state (#7723)Chris2017-10-264-12/+2
| | | | | | | | | | * remove more global refs / state * fix job enterprise initialization * fix api4 test compilation * saml api endpoints fix
* Performance improvements for 40M posts (#7708)Christopher Speller2017-10-2511-81/+75
| | | | | | | | | | | | | | | | | | | | | | * Optimizing get root posts SQL query * Setting session invalidation to be reliable * Adding app reciever to SessionHasPermissionToUser * Adding app reciever to SessionHasPermissionToTeam * Adding app reciever to SessionHasPermissionTo * Clear session cache if permission was denied * Fixing rebase issues * Revert "Optimizing get root posts SQL query" This reverts commit f364757e7015cfb4ec673d0a4fc3d57cd25d8dd7. * Fixing build
* [PLT-7726] adjustments for the mm-server jenkinsfile (#7688)Carlos Tadeu Panato Junior2017-10-251-1/+2
|
* PLT-7599: webhook post splitting (#7707)Chris2017-10-241-2/+2
| | | | | | | | * webhook post splitting * style fix * update old webhook test
* eliminate more utils.Cfg references (#7701)Chris2017-10-244-204/+2
|
* add model.NewX funcs for builtin types (#7692)Chris2017-10-231-2/+1
| | | | | | * add model.NewX funcs for builtin types * whoops, forgot to add the new file
* Reduce cfg boilerplate (#7689)Chris2017-10-236-303/+36
| | | | | | | | | | | | * reduce cfg boilerplate * fix compile error * user test fix * another test fix * simplify diagnostics / testing
* [PLT-7362] Option to add user to channel if mentioned user is not currently ↵Saturnino Abril2017-10-211-1/+9
| | | | | | | | | | | | | | | | in the channel (#7619) * Option to add user to channel if mentioned user is not currently in the channel * instead of link from server, just add component on client side to add channel member * change implementation using post.props * do clean up and add test * sanitize post.props['add_channel_member'] on post creation * move sanitize to app.CreatePost and also apply to app.UpdatePost
* Reduce utils.Cfg references (#7650)Chris2017-10-1827-550/+641
| | | | | | | | | | | | * app.UpdateConfig method * test fix * another test fix * the config override option as-was is just error prone, remove it for now * derp
* fix email race condition (#7656)Chris2017-10-181-2/+5
|
* Merge branch 'release-4.3'Christopher Brown2017-10-164-17/+387
|\
| * fix race condition in tests (#7609)Chris2017-10-111-0/+16
| |
| * PLT-7811 Standardized team sanitization flow (#7586)Harrison Healey2017-10-093-14/+380
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * post-4.3 commit (#7581) * reduce store boiler plate (#7585) * fix GetPostsByIds error (#7591) * PLT-7811 Standardized team sanitization flow * Fixed TestGetAllTeamListings * Stopped sanitizing teams for team admins * Removed debug logging * Added TearDown to sanitization tests that needed it
| * PLT-7818 Updates to post type (#7579)Joram Wilander2017-10-091-3/+7
| | | | | | | | | | | | * Updates to post type * Update tests
* | parallel tests (#7629)Chris2017-10-165-20/+36
| |
* | Use tmpfs containers for api/api4 tests, move and speed up CLI tests (#7606)Chris2017-10-123-419/+103
| | | | | | | | | | | | | | | | | | | | | | | | * use tmpfs containers for api/api4, move and speed up cli tests * minor optimizations * add missing files, fix pre-existing race condition * add . to TestMain check * add requested log message