summaryrefslogtreecommitdiffstats
path: root/plugin/client_rpc.go
Commit message (Collapse)AuthorAgeFilesLines
* MM-12193: remove auto unmarshalling (#9519)Jesse Hallam2018-10-031-4/+9
| | | | | | | | | | | | | | | | * MM-12193: remove auto configuration unmarshalling Since plugin hook events are called concurrently, there's no way for the plugin framework to coordinate safe access to the automatically unmarshalled configuration fields. Remove this functionality, and update documentation to illustrate a safe way to do this. * better Fprint example * fix unit tests * log when OnConfigurationChange fails through OnActivate * clarify lifecycle when OnConfigurationChange returns an error * call SetAPI even if OnConfigurationChange not implemented
* MM-11734: better plugin `error` handling (#9405)Jesse Hallam2018-09-131-2/+29
| | | | | | | | * MM-11734: encode unregistered error implementations as an ErrorString * MM-11734: test error string handling * more idiomatic error handling
* Fix typo (#9347)Chetanya Kandhari2018-09-051-1/+1
|
* add megacheck as makefile target (#9288)Daniel Schalla2018-09-031-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | Fix code issues in channel_test.go Fix Channel Test Issues detected by Megacheck Fix API Emoji Test Issues detected by Megacheck Fixed API Issues Reported by Megacheck Fixed App issues reported by megacheck Remaining fixes removed test added by mistake from old HEAD gofmt Store Fixes simplified returns Fix test for multi member channel delete revert to delete unused function
* gob register AppError (#9182)Jesse Hallam2018-07-311-0/+1
| | | | This allows plugin hooks to return the result of calling the API as an `error`.
* Fix compile error caused by bad merge (#9176)Joram Wilander2018-07-271-1/+1
| | | | | | | | * Fix compile error caused by bad merge * Fix * Fix
* s/mlog/log/ in apiRPCClient (#9171)Jesse Hallam2018-07-271-2/+1
| | | | | We never actually initialized `log` on apiRPCClient, and it can't log without making an RPC call anyway, so just switch to logging errors from the plugin to STDERR instead.
* Adding FileWillBeUploaded plugin hook (#9169)Christopher Speller2018-07-271-1/+88
| | | | | | | | | | | | | | * Adding file upload hook. * Adding hook test for FileWillBeUploaded * Some debugging fixes. * Fix typo. * Fixing double close * Fix capitalization on docs.
* MM-11292: clean up plugins GoDoc (#9109)Jesse Hallam2018-07-131-39/+39
| | | | | | | | | | | | | | | | | | | * clean up plugins GoDoc: - eliminate plugin.NewBlankContext() as unnecessary - export ValidIdRegex as a string vs. the less readable var - add/update various documentation strings - hide everything by default, except where used by client plugins or the mattermost-server. The exception to this rule are the `*(Args|Returns)` structs which must be public for go-plugin, but are now prefixed with `Z_` with a warning not to use. - include a top-level example to get plugin authors started This is not a breaking change for existing plugins compiled against plugins-v2. * remove commented out ServeHTTPResponseWriter * update examples to match developer docs * add missing plugin/doc.go license header
* MM-10703 Adding blank request context to plugin hooks for future use. (#9043)Christopher Speller2018-07-061-3/+7
| | | | | | | | | | * Adding blank request context to plugin hooks for future use. * Rename RequestContext to Context * Adding context to ServeHTTP and ExecuteCommand * Fixing import cycle in test.
* MM-11029 Adding plugin logging functionality. (#9034)Christopher Speller2018-07-031-18/+11
| | | | | | | | | | | | * Capturing stdout, stderr of plugins in logs. * Cleanup go-plugin debug logs. * Adding logging to plugin API * Generating mocks. * godoc convention
* MM-10702 Moving plugins to use hashicorp go-plugin. (#8978)Christopher Speller2018-06-251-0/+331
* Moving plugins to use hashicorp go-plugin. * Tweaks from feedback.