From b9092ca2f56b0fa2b8ec7719c2ec5cfe5a21a6c9 Mon Sep 17 00:00:00 2001 From: Carlos Tadeu Panato Junior Date: Tue, 20 Dec 2016 16:55:22 +0100 Subject: Fix API Get channels for a user returns users' dm channels with blank teamid (#4748) * fix API Get channels for a user returns users' dm channels with blank team ID add check in the context.go add suggestion made adjustment per review and support from @joram * update tests * add check if needd user or admin permissions * update per review --- api/channel_test.go | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) (limited to 'api/channel_test.go') diff --git a/api/channel_test.go b/api/channel_test.go index 683deb8a9..c916a27cf 100644 --- a/api/channel_test.go +++ b/api/channel_test.go @@ -745,10 +745,21 @@ func TestGetChannel(t *testing.T) { t.Fatal("should have failed - bad channel id") } - Client.SetTeamId(team2.Id) + th.BasicClient.SetTeamId(team2.Id) if _, err := Client.GetChannel(channel2.Id, ""); err == nil { t.Fatal("should have failed - wrong team") } + + //Test if a wrong team id is supplied should return error + if _, err := Client.CreateDirectChannel(th.BasicUser2.Id); err != nil { + t.Fatal(err) + } + + th.BasicClient.SetTeamId("nonexitingteamid") + if _, err := Client.GetChannels(""); err == nil { + t.Fatal("should have failed - wrong team id") + } + } func TestGetMoreChannelsPage(t *testing.T) { -- cgit v1.2.3-1-g7c22