From 4ef46db0f68ca1ef31297db465f6f93226e62132 Mon Sep 17 00:00:00 2001 From: Elias Nahum Date: Fri, 22 Jan 2016 02:41:23 -0300 Subject: PLT-7: Change post CreatePost back to model.NewAppError - It was failing test using model.NewLocAppError --- api/post.go | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) (limited to 'api/post.go') diff --git a/api/post.go b/api/post.go index fe89ebf19..a3ce99a14 100644 --- a/api/post.go +++ b/api/post.go @@ -75,12 +75,15 @@ func CreatePost(c *Context, post *model.Post, triggerWebhooks bool) (*model.Post // Verify the parent/child relationships are correct if pchan != nil { + // somehow tests fail here if we use the commented lines if presult := <-pchan; presult.Err != nil { - return nil, model.NewLocAppError("createPost", "api.post.create_post.root_id.app_error", nil, "") + //return nil, model.NewLocAppError("createPost", "api.post.create_post.root_id.app_error", nil, "") + return nil, model.NewAppError("createPost", "Invalid RootId parameter", "") } else { list := presult.Data.(*model.PostList) if len(list.Posts) == 0 || !list.IsChannelId(post.ChannelId) { - return nil, model.NewLocAppError("createPost", "api.post.create_post.channel_root_id.app_error", nil, "") + //return nil, model.NewLocAppError("createPost", "api.post.create_post.channel_root_id.app_error", nil, "") + return nil, model.NewAppError("createPost", "Invalid ChannelId for RootId parameter", "") } if post.ParentId == "" { @@ -90,7 +93,8 @@ func CreatePost(c *Context, post *model.Post, triggerWebhooks bool) (*model.Post if post.RootId != post.ParentId { parent := list.Posts[post.ParentId] if parent == nil { - return nil, model.NewLocAppError("createPost", "api.post.create_post.parent_id.app_error", nil, "") + //return nil, model.NewLocAppError("createPost", "api.post.create_post.parent_id.app_error", nil, "") + return nil, model.NewAppError("createPost", "Invalid ParentId parameter", "") } } } -- cgit v1.2.3-1-g7c22