From 8e19ba029f889519d93cf272960dce858971106c Mon Sep 17 00:00:00 2001 From: Chris Date: Wed, 18 Oct 2017 15:36:43 -0700 Subject: Reduce utils.Cfg references (#7650) * app.UpdateConfig method * test fix * another test fix * the config override option as-was is just error prone, remove it for now * derp --- api4/command_help_test.go | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) (limited to 'api4/command_help_test.go') diff --git a/api4/command_help_test.go b/api4/command_help_test.go index 68a098636..c5ff819b3 100644 --- a/api4/command_help_test.go +++ b/api4/command_help_test.go @@ -7,7 +7,6 @@ import ( "testing" "github.com/mattermost/mattermost-server/model" - "github.com/mattermost/mattermost-server/utils" ) func TestHelpCommand(t *testing.T) { @@ -17,18 +16,20 @@ func TestHelpCommand(t *testing.T) { Client := th.Client channel := th.BasicChannel - HelpLink := *utils.Cfg.SupportSettings.HelpLink + HelpLink := *th.App.Config().SupportSettings.HelpLink defer func() { - *utils.Cfg.SupportSettings.HelpLink = HelpLink + th.App.UpdateConfig(func(cfg *model.Config) { *cfg.SupportSettings.HelpLink = HelpLink }) }() - *utils.Cfg.SupportSettings.HelpLink = "" + th.App.UpdateConfig(func(cfg *model.Config) { *cfg.SupportSettings.HelpLink = "" }) rs1, _ := Client.ExecuteCommand(channel.Id, "/help ") if rs1.GotoLocation != model.SUPPORT_SETTINGS_DEFAULT_HELP_LINK { t.Fatal("failed to default help link") } - *utils.Cfg.SupportSettings.HelpLink = "https://docs.mattermost.com/guides/user.html" + th.App.UpdateConfig(func(cfg *model.Config) { + *cfg.SupportSettings.HelpLink = "https://docs.mattermost.com/guides/user.html" + }) rs2, _ := Client.ExecuteCommand(channel.Id, "/help ") if rs2.GotoLocation != "https://docs.mattermost.com/guides/user.html" { t.Fatal("failed to help link") -- cgit v1.2.3-1-g7c22