From 88b8df314673ceae08a37a6472296448e83d7442 Mon Sep 17 00:00:00 2001 From: Carlos Tadeu Panato Junior Date: Mon, 3 Apr 2017 14:12:50 +0200 Subject: implement GET /commands (#5865) --- api4/command_test.go | 77 ++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 77 insertions(+) (limited to 'api4/command_test.go') diff --git a/api4/command_test.go b/api4/command_test.go index aa3ad37b6..3c8076470 100644 --- a/api4/command_test.go +++ b/api4/command_test.go @@ -59,3 +59,80 @@ func TestCreateCommand(t *testing.T) { CheckNotImplementedStatus(t, resp) CheckErrorMessage(t, resp, "api.command.disabled.app_error") } + +func TestListCommands(t *testing.T) { + th := Setup().InitBasic().InitSystemAdmin() + defer TearDown() + Client := th.Client + + newCmd := &model.Command{ + CreatorId: th.BasicUser.Id, + TeamId: th.BasicTeam.Id, + URL: "http://nowhere.com", + Method: model.COMMAND_METHOD_POST, + Trigger: "custom_command"} + + _, resp := th.SystemAdminClient.CreateCommand(newCmd) + CheckNoError(t, resp) + + t.Run("ListSystemAndCustomCommands", func(t *testing.T) { + listCommands, resp := th.SystemAdminClient.ListCommands(th.BasicTeam.Id, false) + CheckNoError(t, resp) + + foundEcho := false + foundCustom := false + for _, command := range listCommands { + if command.Trigger == "echo" { + foundEcho = true + } + if command.Trigger == "custom_command" { + foundCustom = true + } + } + if !foundEcho { + t.Fatal("Couldn't find echo command") + } + if !foundCustom { + t.Fatal("Should list the custom command") + } + }) + + t.Run("ListCustomOnlyCommands", func(t *testing.T) { + listCommands, resp := th.SystemAdminClient.ListCommands(th.BasicTeam.Id, true) + CheckNoError(t, resp) + + if len(listCommands) > 1 { + t.Fatal("Should list just one custom command") + } + if listCommands[0].Trigger != "custom_command" { + t.Fatal("Wrong custom command trigger") + } + }) + + t.Run("UserWithNoPermissionForCustomCommands", func(t *testing.T) { + _, resp := Client.ListCommands(th.BasicTeam.Id, true) + CheckForbiddenStatus(t, resp) + }) + + t.Run("RegularUserCanListOnlySystemCommands", func(t *testing.T) { + listCommands, resp := Client.ListCommands(th.BasicTeam.Id, false) + CheckNoError(t, resp) + + foundEcho := false + foundCustom := false + for _, command := range listCommands { + if command.Trigger == "echo" { + foundEcho = true + } + if command.Trigger == "custom_command" { + foundCustom = true + } + } + if !foundEcho { + t.Fatal("Couldn't find echo command") + } + if foundCustom { + t.Fatal("Should not list the custom command") + } + }) +} -- cgit v1.2.3-1-g7c22