From 59319b7915b8eb4c20a0d4878382cc0e41fc536d Mon Sep 17 00:00:00 2001 From: Jesse Hallam Date: Tue, 9 Oct 2018 15:25:57 -0400 Subject: MM-12519: simplify autocomplete team id checking (#9577) This handles clients sending a team id in a direct message or group channel autocomplete, when it necessarily won't match. Just verify that the user has permission for the team in question, whenever it is provided. --- api4/user_test.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'api4/user_test.go') diff --git a/api4/user_test.go b/api4/user_test.go index d50dfa3b6..405102373 100644 --- a/api4/user_test.go +++ b/api4/user_test.go @@ -873,9 +873,9 @@ func TestAutocompleteUsers(t *testing.T) { t.Fatal("should not show first/last name") } - t.Run("team id, if provided, must match channel's team id", func(t *testing.T) { + t.Run("user must have access to team id, especially when it does not match channel's team id", func(t *testing.T) { rusers, resp = Client.AutocompleteUsersInChannel("otherTeamId", channelId, username, "") - CheckErrorMessage(t, resp, "api.user.autocomplete_users.invalid_team_id") + CheckErrorMessage(t, resp, "api.context.permissions.app_error") }) } -- cgit v1.2.3-1-g7c22