From 638c38cc0d2296335a0fbd5bde8b6d2cbf9f9062 Mon Sep 17 00:00:00 2001 From: George Goldberg Date: Fri, 11 Aug 2017 18:20:10 +0100 Subject: PLT-7336: Fix team API endpoints. --- api/team.go | 6 +++--- api/team_test.go | 19 +++++++++++++++++++ 2 files changed, 22 insertions(+), 3 deletions(-) (limited to 'api') diff --git a/api/team.go b/api/team.go index a2ac50116..b1fcdfd78 100644 --- a/api/team.go +++ b/api/team.go @@ -22,11 +22,11 @@ func InitTeam() { l4g.Debug(utils.T("api.team.init.debug")) BaseRoutes.Teams.Handle("/create", ApiUserRequired(createTeam)).Methods("POST") - BaseRoutes.Teams.Handle("/all", ApiAppHandler(getAll)).Methods("GET") + BaseRoutes.Teams.Handle("/all", ApiUserRequired(getAll)).Methods("GET") BaseRoutes.Teams.Handle("/all_team_listings", ApiUserRequired(GetAllTeamListings)).Methods("GET") BaseRoutes.Teams.Handle("/get_invite_info", ApiAppHandler(getInviteInfo)).Methods("POST") - BaseRoutes.Teams.Handle("/find_team_by_name", ApiAppHandler(findTeamByName)).Methods("POST") - BaseRoutes.Teams.Handle("/name/{team_name:[A-Za-z0-9\\-]+}", ApiAppHandler(getTeamByName)).Methods("GET") + BaseRoutes.Teams.Handle("/find_team_by_name", ApiUserRequired(findTeamByName)).Methods("POST") + BaseRoutes.Teams.Handle("/name/{team_name:[A-Za-z0-9\\-]+}", ApiUserRequired(getTeamByName)).Methods("GET") BaseRoutes.Teams.Handle("/members", ApiUserRequired(getMyTeamMembers)).Methods("GET") BaseRoutes.Teams.Handle("/unread", ApiUserRequired(getMyTeamsUnread)).Methods("GET") diff --git a/api/team_test.go b/api/team_test.go index 14c9311a3..3c05588ce 100644 --- a/api/team_test.go +++ b/api/team_test.go @@ -239,6 +239,11 @@ func TestGetAllTeams(t *testing.T) { } else if receivedTeam, ok := teams[team.Id]; !ok || receivedTeam.Id != team.Id { t.Fatal("admin should've received team that they aren't a member of") } + + Client.Logout() + if _, err := Client.GetAllTeams(); err == nil { + t.Fatal("Should have failed due to not being logged in.") + } } func TestGetAllTeamListings(t *testing.T) { @@ -855,4 +860,18 @@ func TestGetTeamByName(t *testing.T) { t.Fatal("Should not exist this team") } + Client.Logout() + if _, err := Client.GetTeamByName(th.BasicTeam.Name); err == nil { + t.Fatal("Should have failed when not logged in.") + } +} + +func TestFindTeamByName(t *testing.T) { + th := Setup().InitBasic() + Client := th.BasicClient + Client.Logout() + + if _, err := Client.FindTeamByName(th.BasicTeam.Name); err == nil { + t.Fatal("Should have failed when not logged in.") + } } -- cgit v1.2.3-1-g7c22