From 99b7d65504ce729db4255f2d31def0859d36e87f Mon Sep 17 00:00:00 2001 From: Corey Hulen Date: Tue, 19 Sep 2017 13:34:39 -0700 Subject: Fixing profile image tag (#7435) * Fixing profile image tag * Fixing unit test * Fixing unit test --- api/user.go | 2 +- api/user_test.go | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) (limited to 'api') diff --git a/api/user.go b/api/user.go index d95d775e4..1ca46bd56 100644 --- a/api/user.go +++ b/api/user.go @@ -571,10 +571,10 @@ func getProfileImage(c *Context, w http.ResponseWriter, r *http.Request) { w.Header().Set("Cache-Control", "max-age=300, public") // 5 mins } else { w.Header().Set("Cache-Control", "max-age=86400, public") // 24 hrs + w.Header().Set(model.HEADER_ETAG_SERVER, etag) } w.Header().Set("Content-Type", "image/png") - w.Header().Set(model.HEADER_ETAG_SERVER, etag) w.Write(img) } } diff --git a/api/user_test.go b/api/user_test.go index 44ee1bfb0..5b6309bcf 100644 --- a/api/user_test.go +++ b/api/user_test.go @@ -684,8 +684,8 @@ func TestUserCreateImage(t *testing.T) { } else { etag := resp.Header.Get(model.HEADER_ETAG_SERVER) resp2, _ := Client.DoApiGet("/users/"+user.Id+"/image", "", etag) - if resp2.StatusCode != 304 { - t.Fatal("Should have hit etag") + if resp2.StatusCode == 304 { + t.Fatal("Shouldn't have hit etag") } } -- cgit v1.2.3-1-g7c22