From a840fc285bfead1e5a28b5293e58bdeb8c33f2b6 Mon Sep 17 00:00:00 2001 From: George Goldberg Date: Sun, 8 Jul 2018 10:27:13 +0100 Subject: MM-11194: Fix channel header slash command. (#9057) --- app/command_channel_header_test.go | 82 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 82 insertions(+) (limited to 'app/command_channel_header_test.go') diff --git a/app/command_channel_header_test.go b/app/command_channel_header_test.go index 2a6151fed..21735e044 100644 --- a/app/command_channel_header_test.go +++ b/app/command_channel_header_test.go @@ -12,6 +12,8 @@ func TestHeaderProviderDoCommand(t *testing.T) { defer th.TearDown() hp := HeaderProvider{} + + // Try a public channel *with* permission. args := &model.CommandArgs{ T: func(s string, args ...interface{}) string { return s }, ChannelId: th.BasicChannel.Id, @@ -25,4 +27,84 @@ func TestHeaderProviderDoCommand(t *testing.T) { actual := hp.DoCommand(th.App, args, msg).Text assert.Equal(t, expected, actual) } + + // Try a public channel *without* permission. + args = &model.CommandArgs{ + T: func(s string, args ...interface{}) string { return s }, + ChannelId: th.BasicChannel.Id, + Session: model.Session{UserId: th.BasicUser.Id, TeamMembers: []*model.TeamMember{{TeamId: th.BasicTeam.Id, Roles: ""}}}, + } + + actual := hp.DoCommand(th.App, args, "hello").Text + assert.Equal(t, "api.command_channel_header.permission.app_error", actual) + + // Try a private channel *with* permission. + privateChannel := th.CreatePrivateChannel(th.BasicTeam) + + args = &model.CommandArgs{ + T: func(s string, args ...interface{}) string { return s }, + ChannelId: privateChannel.Id, + Session: model.Session{UserId: th.BasicUser.Id, TeamMembers: []*model.TeamMember{{TeamId: th.BasicTeam.Id, Roles: model.TEAM_USER_ROLE_ID}}}, + } + + actual = hp.DoCommand(th.App, args, "hello").Text + assert.Equal(t, "", actual) + + // Try a private channel *without* permission. + args = &model.CommandArgs{ + T: func(s string, args ...interface{}) string { return s }, + ChannelId: privateChannel.Id, + Session: model.Session{UserId: th.BasicUser.Id, TeamMembers: []*model.TeamMember{{TeamId: th.BasicTeam.Id, Roles: ""}}}, + } + + actual = hp.DoCommand(th.App, args, "hello").Text + assert.Equal(t, "api.command_channel_header.permission.app_error", actual) + + // Try a group channel *with* being a member. + user1 := th.CreateUser() + user2 := th.CreateUser() + user3 := th.CreateUser() + + groupChannel := th.CreateGroupChannel(user1, user2) + + args = &model.CommandArgs{ + T: func(s string, args ...interface{}) string { return s }, + ChannelId: groupChannel.Id, + Session: model.Session{UserId: th.BasicUser.Id, TeamMembers: []*model.TeamMember{{TeamId: th.BasicTeam.Id, Roles: ""}}}, + } + + actual = hp.DoCommand(th.App, args, "hello").Text + assert.Equal(t, "", actual) + + // Try a group channel *without* being a member. + args = &model.CommandArgs{ + T: func(s string, args ...interface{}) string { return s }, + ChannelId: groupChannel.Id, + Session: model.Session{UserId: user3.Id, TeamMembers: []*model.TeamMember{{TeamId: th.BasicTeam.Id, Roles: ""}}}, + } + + actual = hp.DoCommand(th.App, args, "hello").Text + assert.Equal(t, "api.command_channel_header.permission.app_error", actual) + + // Try a direct channel *with* being a member. + directChannel := th.CreateDmChannel(user1) + + args = &model.CommandArgs{ + T: func(s string, args ...interface{}) string { return s }, + ChannelId: directChannel.Id, + Session: model.Session{UserId: th.BasicUser.Id, TeamMembers: []*model.TeamMember{{TeamId: th.BasicTeam.Id, Roles: ""}}}, + } + + actual = hp.DoCommand(th.App, args, "hello").Text + assert.Equal(t, "", actual) + + // Try a direct channel *without* being a member. + args = &model.CommandArgs{ + T: func(s string, args ...interface{}) string { return s }, + ChannelId: directChannel.Id, + Session: model.Session{UserId: user2.Id, TeamMembers: []*model.TeamMember{{TeamId: th.BasicTeam.Id, Roles: ""}}}, + } + + actual = hp.DoCommand(th.App, args, "hello").Text + assert.Equal(t, "api.command_channel_header.permission.app_error", actual) } -- cgit v1.2.3-1-g7c22