From 0dbaa2d032ae42cbf39945df12efb20fc572b559 Mon Sep 17 00:00:00 2001 From: Carlos Tadeu Panato Junior Date: Fri, 11 May 2018 17:20:47 +0200 Subject: [MM-10458] Change system response to "Could not find the channel" - bug fix (#8738) * [MM-10458] Change system response to "Could not find the channel" when trying to invite user to private channel you can't see * add another check to check if user have permission to add another in pvt channel --- app/command_invite_test.go | 7 +++++++ 1 file changed, 7 insertions(+) (limited to 'app/command_invite_test.go') diff --git a/app/command_invite_test.go b/app/command_invite_test.go index c46bc4628..0d1db4a07 100644 --- a/app/command_invite_test.go +++ b/app/command_invite_test.go @@ -18,6 +18,7 @@ func TestInviteProvider(t *testing.T) { channel := th.createChannel(th.BasicTeam, model.CHANNEL_OPEN) privateChannel := th.createChannel(th.BasicTeam, model.CHANNEL_PRIVATE) dmChannel := th.CreateDmChannel(th.BasicUser2) + privateChannel2 := th.createChannelWithAnotherUser(th.BasicTeam, model.CHANNEL_PRIVATE, th.BasicUser2.Id) basicUser3 := th.CreateUser() th.LinkUserToTeam(basicUser3, th.BasicTeam) @@ -36,6 +37,7 @@ func TestInviteProvider(t *testing.T) { userAndDisplayChannel := "@" + th.BasicUser2.Username + " ~" + channel.DisplayName + " " userAndPrivateChannel := "@" + th.BasicUser2.Username + " ~" + privateChannel.Name userAndDMChannel := "@" + basicUser3.Username + " ~" + dmChannel.Name + userAndInvalidPrivate := "@" + basicUser3.Username + " ~" + privateChannel2.Name tests := []struct { desc string @@ -97,6 +99,11 @@ func TestInviteProvider(t *testing.T) { expected: "api.command_invite.directchannel.app_error", msg: userAndDMChannel, }, + { + desc: "try to add a user to a privante channel with no permission", + expected: "api.command_invite.private_channel.app_error", + msg: userAndInvalidPrivate, + }, } for _, test := range tests { -- cgit v1.2.3-1-g7c22