From 908a682fcf3bbc48db75099f636d627616757b24 Mon Sep 17 00:00:00 2001 From: Jesse Hallam Date: Fri, 20 Jul 2018 12:03:08 -0400 Subject: make GetChannelByName take teamId first (#9134) * make GetChannelByName take teamId first I think it is more natural to accept `teamId`, then `channelName`, given the pattern followed by other Plugin API methods and even the SQL Store itself. The App layer seems unusual in accepting `channelName` first. This also re-generates the mocks fixing the parameter order for the recently added `UserStatus` APIs. * add GetChannelByNameForTeamName --- app/plugin_api.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'app/plugin_api.go') diff --git a/app/plugin_api.go b/app/plugin_api.go index d7b116c0f..5e603a44e 100644 --- a/app/plugin_api.go +++ b/app/plugin_api.go @@ -190,10 +190,14 @@ func (api *PluginAPI) GetChannel(channelId string) (*model.Channel, *model.AppEr return api.app.GetChannel(channelId) } -func (api *PluginAPI) GetChannelByName(name, teamId string) (*model.Channel, *model.AppError) { +func (api *PluginAPI) GetChannelByName(teamId, name string) (*model.Channel, *model.AppError) { return api.app.GetChannelByName(name, teamId) } +func (api *PluginAPI) GetChannelByNameForTeamName(teamName, channelName string) (*model.Channel, *model.AppError) { + return api.app.GetChannelByNameForTeamName(channelName, teamName) +} + func (api *PluginAPI) GetDirectChannel(userId1, userId2 string) (*model.Channel, *model.AppError) { return api.app.GetDirectChannel(userId1, userId2) } -- cgit v1.2.3-1-g7c22