From 034dbc07e3068c482e654b6a1a8fcbe4b01c44f3 Mon Sep 17 00:00:00 2001 From: Pierre de La Morinerie Date: Tue, 6 Feb 2018 10:57:34 +0530 Subject: handle RateLimiter initialization errors (#8199) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Previously, an error occuring in NewRateLimiter would return a nil reference – which would be de-referenced just after, making the server crash. --- app/ratelimit.go | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) (limited to 'app/ratelimit.go') diff --git a/app/ratelimit.go b/app/ratelimit.go index 460088598..13508f36f 100644 --- a/app/ratelimit.go +++ b/app/ratelimit.go @@ -12,6 +12,7 @@ import ( l4g "github.com/alecthomas/log4go" "github.com/mattermost/mattermost-server/model" "github.com/mattermost/mattermost-server/utils" + "github.com/pkg/errors" throttled "gopkg.in/throttled/throttled.v2" "gopkg.in/throttled/throttled.v2/store/memstore" ) @@ -23,11 +24,10 @@ type RateLimiter struct { header string } -func NewRateLimiter(settings *model.RateLimitSettings) *RateLimiter { +func NewRateLimiter(settings *model.RateLimitSettings) (*RateLimiter, error) { store, err := memstore.New(*settings.MemoryStoreSize) if err != nil { - l4g.Critical(utils.T("api.server.start_server.rate_limiting_memory_store")) - return nil + return nil, errors.Wrap(err, utils.T("api.server.start_server.rate_limiting_memory_store")) } quota := throttled.RateQuota{ @@ -37,8 +37,7 @@ func NewRateLimiter(settings *model.RateLimitSettings) *RateLimiter { throttledRateLimiter, err := throttled.NewGCRARateLimiter(store, quota) if err != nil { - l4g.Critical(utils.T("api.server.start_server.rate_limiting_rate_limiter")) - return nil + return nil, errors.Wrap(err, utils.T("api.server.start_server.rate_limiting_rate_limiter")) } return &RateLimiter{ @@ -46,7 +45,7 @@ func NewRateLimiter(settings *model.RateLimitSettings) *RateLimiter { useAuth: *settings.VaryByUser, useIP: *settings.VaryByRemoteAddr, header: settings.VaryByHeader, - } + }, nil } func (rl *RateLimiter) GenerateKey(r *http.Request) string { -- cgit v1.2.3-1-g7c22