From d5dbdb273703a3add0f1c3287aa531854ab30269 Mon Sep 17 00:00:00 2001 From: Chris Date: Fri, 3 Nov 2017 10:25:38 -0500 Subject: several one-line panic, race, and logic fixes (#7766) --- app/user.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'app/user.go') diff --git a/app/user.go b/app/user.go index 9f74ef303..999fabbf8 100644 --- a/app/user.go +++ b/app/user.go @@ -774,10 +774,10 @@ func (a *App) GetProfileImage(user *model.User) ([]byte, bool, *model.AppError) func (a *App) SetProfileImage(userId string, imageData *multipart.FileHeader) *model.AppError { file, err := imageData.Open() - defer file.Close() if err != nil { return model.NewAppError("SetProfileImage", "api.user.upload_profile_user.open.app_error", nil, err.Error(), http.StatusBadRequest) } + defer file.Close() // Decode image config first to check dimensions before loading the whole thing into memory later on config, _, err := image.DecodeConfig(file) -- cgit v1.2.3-1-g7c22