From 9220254f05b6200de2e8ac78476a8df536c821ec Mon Sep 17 00:00:00 2001 From: Joram Wilander Date: Thu, 23 Feb 2017 03:53:33 -0500 Subject: Block OAuth account creation when disabled in config (#5506) --- app/user_test.go | 34 ++++++++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+) (limited to 'app/user_test.go') diff --git a/app/user_test.go b/app/user_test.go index 5b994d219..0dba86241 100644 --- a/app/user_test.go +++ b/app/user_test.go @@ -4,7 +4,12 @@ package app import ( + "strings" "testing" + + "github.com/mattermost/platform/model" + "github.com/mattermost/platform/model/gitlab" + "github.com/mattermost/platform/utils" ) func TestIsUsernameTaken(t *testing.T) { @@ -51,3 +56,32 @@ func TestCheckUserDomain(t *testing.T) { } } } + +func TestCreateOAuthUser(t *testing.T) { + th := Setup().InitBasic() + glUser := oauthgitlab.GitLabUser{Id: 1000, Username: model.NewId(), Email: model.NewId() + "@simulator.amazonses.com", Name: "Joram Wilander"} + + json := glUser.ToJson() + user, err := CreateOAuthUser(model.USER_AUTH_SERVICE_GITLAB, strings.NewReader(json), th.BasicTeam.Id) + if err != nil { + t.Fatal(err) + } + + if user.Username != glUser.Username { + t.Fatal("usernames didn't match") + } + + PermanentDeleteUser(user) + + userCreation := utils.Cfg.TeamSettings.EnableUserCreation + defer func() { + utils.Cfg.TeamSettings.EnableUserCreation = userCreation + }() + utils.Cfg.TeamSettings.EnableUserCreation = false + + _, err = CreateOAuthUser(model.USER_AUTH_SERVICE_GITLAB, strings.NewReader(json), th.BasicTeam.Id) + if err == nil { + t.Fatal("should have failed - user creation disabled") + } + +} -- cgit v1.2.3-1-g7c22