From ce2b2be5de578bd9eb44b26e04db75ca61d67ca5 Mon Sep 17 00:00:00 2001 From: Chris Date: Tue, 31 Oct 2017 09:39:31 -0500 Subject: Refactoring cfg refs and load / save functions (#7749) * refactoring cfg refs and load / save functions * improve error output --- cmd/platform/test.go | 23 ++++++++++++----------- cmd/platform/user.go | 2 +- 2 files changed, 13 insertions(+), 12 deletions(-) (limited to 'cmd/platform') diff --git a/cmd/platform/test.go b/cmd/platform/test.go index 08438e034..faf265a0d 100644 --- a/cmd/platform/test.go +++ b/cmd/platform/test.go @@ -14,6 +14,7 @@ import ( "github.com/mattermost/mattermost-server/api" "github.com/mattermost/mattermost-server/api4" + "github.com/mattermost/mattermost-server/model" "github.com/mattermost/mattermost-server/utils" "github.com/mattermost/mattermost-server/wsapi" "github.com/spf13/cobra" @@ -51,12 +52,12 @@ func webClientTestsCmdF(cmd *cobra.Command, args []string) error { } defer a.Shutdown() - utils.InitTranslations(utils.Cfg.LocalizationSettings) + utils.InitTranslations(a.Config().LocalizationSettings) a.StartServer() api4.Init(a, a.Srv.Router, false) api.Init(a, a.Srv.Router) wsapi.Init(a, a.Srv.WebSocketRouter) - setupClientTests() + a.UpdateConfig(setupClientTests) runWebClientTests() return nil @@ -69,12 +70,12 @@ func serverForWebClientTestsCmdF(cmd *cobra.Command, args []string) error { } defer a.Shutdown() - utils.InitTranslations(utils.Cfg.LocalizationSettings) + utils.InitTranslations(a.Config().LocalizationSettings) a.StartServer() api4.Init(a, a.Srv.Router, false) api.Init(a, a.Srv.Router) wsapi.Init(a, a.Srv.WebSocketRouter) - setupClientTests() + a.UpdateConfig(setupClientTests) c := make(chan os.Signal) signal.Notify(c, os.Interrupt, syscall.SIGINT, syscall.SIGTERM) @@ -83,13 +84,13 @@ func serverForWebClientTestsCmdF(cmd *cobra.Command, args []string) error { return nil } -func setupClientTests() { - *utils.Cfg.TeamSettings.EnableOpenServer = true - *utils.Cfg.ServiceSettings.EnableCommands = false - *utils.Cfg.ServiceSettings.EnableOnlyAdminIntegrations = false - *utils.Cfg.ServiceSettings.EnableCustomEmoji = true - utils.Cfg.ServiceSettings.EnableIncomingWebhooks = false - utils.Cfg.ServiceSettings.EnableOutgoingWebhooks = false +func setupClientTests(cfg *model.Config) { + *cfg.TeamSettings.EnableOpenServer = true + *cfg.ServiceSettings.EnableCommands = false + *cfg.ServiceSettings.EnableOnlyAdminIntegrations = false + *cfg.ServiceSettings.EnableCustomEmoji = true + cfg.ServiceSettings.EnableIncomingWebhooks = false + cfg.ServiceSettings.EnableOutgoingWebhooks = false utils.SetDefaultRolesBasedOnConfig() } diff --git a/cmd/platform/user.go b/cmd/platform/user.go index bc5838795..66b0f2223 100644 --- a/cmd/platform/user.go +++ b/cmd/platform/user.go @@ -289,7 +289,7 @@ func inviteUser(a *app.App, email string, team *model.Team, teamArg string) erro return fmt.Errorf("Can't find team '%v'", teamArg) } - a.SendInviteEmails(team, "Administrator", invites, *utils.Cfg.ServiceSettings.SiteURL) + a.SendInviteEmails(team, "Administrator", invites, *a.Config().ServiceSettings.SiteURL) CommandPrettyPrintln("Invites may or may not have been sent.") return nil -- cgit v1.2.3-1-g7c22