From 3b57422c5fb6f6631a96c1c6a5d730b1db6e4b2a Mon Sep 17 00:00:00 2001 From: Elias Nahum Date: Tue, 1 May 2018 11:07:56 -0300 Subject: translations PR 20180430 (#8696) --- i18n/en.json | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) (limited to 'i18n/en.json') diff --git a/i18n/en.json b/i18n/en.json index a3ba5c4f3..0afaa326c 100644 --- a/i18n/en.json +++ b/i18n/en.json @@ -2434,6 +2434,10 @@ "id": "api.team.permanent_delete_team.deleted.warn", "translation": "Permanently deleted team %v id=%v" }, + { + "id": "api.team.remove_team_icon.get_team.app_error", + "translation": "An error occurred getting the team" + }, { "id": "api.team.remove_user_from_team.missing.app_error", "translation": "The user does not appear to be part of this team." @@ -2458,10 +2462,6 @@ "id": "api.team.set_team_icon.encode.app_error", "translation": "Could not encode team icon" }, - { - "id": "api.team.remove_team_icon.get_team.app_error", - "translation": "An error occurred getting the team" - }, { "id": "api.team.set_team_icon.get_team.app_error", "translation": "An error occurred getting the team" @@ -2486,10 +2486,6 @@ "id": "api.team.set_team_icon.too_large.app_error", "translation": "Unable to upload team icon. File is too large." }, - { - "id": "api.team.team_icon.update.app_error", - "translation": "An error occurred updating the team icon" - }, { "id": "api.team.set_team_icon.write_file.app_error", "translation": "Could not save team icon" @@ -2498,6 +2494,10 @@ "id": "api.team.signup_team.email_disabled.app_error", "translation": "Team sign-up with email is disabled." }, + { + "id": "api.team.team_icon.update.app_error", + "translation": "An error occurred updating the team icon" + }, { "id": "api.team.update_member_roles.not_a_member", "translation": "Specified user is not a member of specified team." -- cgit v1.2.3-1-g7c22 From 1e6553704d372f82e937094721d3b83ccb3fa6de Mon Sep 17 00:00:00 2001 From: Jesse Hallam Date: Tue, 1 May 2018 10:34:12 -0400 Subject: MM-8622: improved plugin error handling (#8692) * don't report an error on plugin activation if already active * improved plugin logging events Log an error when a plugin's ServeHTTP fails, or when it unexpectedly terminates. Restart a plugin at most three times, allowing its failure to later bubble up under the "failed to stay running" status. * clarified plugin activation/deactivation Avoid repeatedly activating when any configuration bit changes. Improved logging. * constrain plugin ids to ^[a-zA-Z0-9-_\.]+$ and enforce minimum length Previously, the plugin id was used unsanitized to relocate the plugin bundle, which allowed writing outside the `plugins/` directory by using an `id` containing `../`. Similarly, an empty string was accepted as an id and led to unexpected error messages. * remove plugins by manifest path, not id If the id within the manifest ever diverges from the actual plugin location, it becomes impossible to remove via the API. Instead, if the plugin is found by id, remove the path containing the manifest. * ignore plugins with nil manifests If a plugin was detected, but had a manifest that couldn't be parsed, it will be left nil but still be listed among the packages. Skip over these in most cases to avoid segfaults. * leverage mlog more effectively for plugins * build issues --- i18n/en.json | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'i18n/en.json') diff --git a/i18n/en.json b/i18n/en.json index 0afaa326c..d4a08b07a 100644 --- a/i18n/en.json +++ b/i18n/en.json @@ -3812,7 +3812,7 @@ }, { "id": "app.plugin.activate.app_error", - "translation": "Unable to activate extracted plugin. Plugin may already exist and be activated." + "translation": "Unable to activate extracted plugin." }, { "id": "app.plugin.cluster.save_config.app_error", @@ -3847,8 +3847,8 @@ "translation": "Unable to get active plugins" }, { - "id": "app.plugin.id_length.app_error", - "translation": "Plugin Id must be less than {{.Max}} characters." + "id": "app.plugin.invalid_id.app_error", + "translation": "Plugin Id must be at least {{.Min}} characters, at most {{.Max}} characters and match {{.Regex}}." }, { "id": "app.plugin.install.app_error", -- cgit v1.2.3-1-g7c22