From 1e6553704d372f82e937094721d3b83ccb3fa6de Mon Sep 17 00:00:00 2001 From: Jesse Hallam Date: Tue, 1 May 2018 10:34:12 -0400 Subject: MM-8622: improved plugin error handling (#8692) * don't report an error on plugin activation if already active * improved plugin logging events Log an error when a plugin's ServeHTTP fails, or when it unexpectedly terminates. Restart a plugin at most three times, allowing its failure to later bubble up under the "failed to stay running" status. * clarified plugin activation/deactivation Avoid repeatedly activating when any configuration bit changes. Improved logging. * constrain plugin ids to ^[a-zA-Z0-9-_\.]+$ and enforce minimum length Previously, the plugin id was used unsanitized to relocate the plugin bundle, which allowed writing outside the `plugins/` directory by using an `id` containing `../`. Similarly, an empty string was accepted as an id and led to unexpected error messages. * remove plugins by manifest path, not id If the id within the manifest ever diverges from the actual plugin location, it becomes impossible to remove via the API. Instead, if the plugin is found by id, remove the path containing the manifest. * ignore plugins with nil manifests If a plugin was detected, but had a manifest that couldn't be parsed, it will be left nil but still be listed among the packages. Skip over these in most cases to avoid segfaults. * leverage mlog more effectively for plugins * build issues --- mlog/log.go | 1 + 1 file changed, 1 insertion(+) (limited to 'mlog') diff --git a/mlog/log.go b/mlog/log.go index 22db0c7b1..ad537a11d 100644 --- a/mlog/log.go +++ b/mlog/log.go @@ -29,6 +29,7 @@ type Field = zapcore.Field var Int64 = zap.Int64 var Int = zap.Int var String = zap.String +var Err = zap.Error type LoggerConfiguration struct { EnableConsole bool -- cgit v1.2.3-1-g7c22