From 2e5617c29be69637acd384e85f795a0b343bec8d Mon Sep 17 00:00:00 2001 From: Corey Hulen Date: Thu, 21 Apr 2016 22:37:01 -0700 Subject: PLT-2057 User as a first class object (#2648) * Adding TeamMember to system * Fixing all unit tests on the backend * Fixing merge conflicts * Fixing merge conflict * Adding javascript unit tests * Adding TeamMember to system * Fixing all unit tests on the backend * Fixing merge conflicts * Fixing merge conflict * Adding javascript unit tests * Adding client side unit test * Cleaning up the clint side tests * Fixing msg * Adding more client side unit tests * Adding more using tests * Adding last bit of client side unit tests and adding make cmd * Fixing bad merge * Fixing libraries * Updating to new client side API * Fixing borken unit test * Fixing unit tests * ugg...trying to beat gofmt * ugg...trying to beat gofmt * Cleaning up remainder of the server side routes * Adding inital load api * Increased coverage of webhook unit tests (#2660) * Adding loading ... to root html * Fixing bad merge * Removing explicit content type so superagent will guess corectly (#2685) * Fixing merge and unit tests * Adding create team UI * Fixing signup flows * Adding LDAP unit tests and enterprise unit test helper (#2702) * Add the ability to reset MFA from the commandline (#2706) * Fixing compliance unit tests * Fixing client side tests * Adding open server to system console * Moving websocket connection * Fixing unit test * Fixing unit tests * Fixing unit tests * Adding nickname and more LDAP unit tests (#2717) * Adding join open teams * Cleaning up all TODOs in the code * Fixing web sockets * Removing unused webockets file * PLT-2533 Add the ability to reset a user's MFA from the system console (#2715) * Add the ability to reset a user's MFA from the system console * Add client side unit test for adminResetMfa * Reorganizing authentication to fix LDAP error message (#2723) * Fixing failing unit test * Initial upgrade db code * Adding upgrade script * Fixing upgrade script after running on core * Update OAuth and Claim routes to work with user model changes (#2739) * Fixing perminant deletion. Adding ability to delete all user and the entire database (#2740) * Fixing team invite ldap login call (#2741) * Fixing bluebar and some img stuff * Fix all the different file upload web utils (#2743) * Fixing invalid session redirect (#2744) * Redirect on bad channel name (#2746) * Fixing a bunch of issue and removing dead code * Patch to fix error message on leave channel (#2747) * Setting EnableOpenServer to false by default * Fixing config * Fixing upgrade * Fixing reported bugs * Bug fixes for PLT-2057 * PLT-2563 Redo password recovery to use a database table (#2745) * Redo password recovery to use a database table * Update reset password audits * Split out admin and user reset password APIs to be separate * Delete password recovery when user is permanently deleted * Consolidate password resetting into a single function * Removed private channels as an option for outgoing webhooks (#2752) * PLT-2577/PLT-2552 Fixes for backstage (#2753) * Added URL to incoming webhook list * Fixed client functions for adding/removing integrations * Disallowed slash commands without trigger words * Fixed clientside handling of errors on AddCommand page * Minor auth cleanup (#2758) * Changed EditPostModal to just close if you save without making any changes (#2759) * Renamed client -> Client in async_client.jsx and fixed eslint warnings (#2756) * Fixed url in channel info modal (#2755) * Fixing reported issues * Moving to version 3 of the apis * Fixing command unit tests (#2760) * Adding team admins * Fixing DM issue * Fixing eslint error * Properly set EditPostModal's originalText state in all cases (#2762) * Update client config check to assume features is defined if server is licensed (#2772) * Fixing url link * Fixing issue with websocket crashing when sending messages to different teams --- model/command_test.go | 81 +++++++++++++++++++++++++++++++++++++++++++-------- 1 file changed, 69 insertions(+), 12 deletions(-) (limited to 'model/command_test.go') diff --git a/model/command_test.go b/model/command_test.go index d362d8f2c..2376e2ef7 100644 --- a/model/command_test.go +++ b/model/command_test.go @@ -19,63 +19,115 @@ func TestCommandJson(t *testing.T) { } func TestCommandIsValid(t *testing.T) { - o := Command{} + o := Command{ + Id: NewId(), + Token: NewId(), + CreateAt: GetMillis(), + UpdateAt: GetMillis(), + CreatorId: NewId(), + TeamId: NewId(), + Trigger: "trigger", + URL: "http://example.com", + Method: COMMAND_METHOD_GET, + DisplayName: "", + Description: "", + } + if err := o.IsValid(); err != nil { + t.Fatal(err) + } + + o.Id = "" if err := o.IsValid(); err == nil { t.Fatal("should be invalid") } o.Id = NewId() + if err := o.IsValid(); err != nil { + t.Fatal(err) + } + + o.Token = "" if err := o.IsValid(); err == nil { t.Fatal("should be invalid") } - o.CreateAt = GetMillis() + o.Token = NewId() + if err := o.IsValid(); err != nil { + t.Fatal(err) + } + + o.CreateAt = 0 if err := o.IsValid(); err == nil { t.Fatal("should be invalid") } - o.UpdateAt = GetMillis() + o.CreateAt = GetMillis() + if err := o.IsValid(); err != nil { + t.Fatal(err) + } + + o.UpdateAt = 0 if err := o.IsValid(); err == nil { t.Fatal("should be invalid") } - o.CreatorId = "123" + o.UpdateAt = GetMillis() + if err := o.IsValid(); err != nil { + t.Fatal(err) + } + + o.CreatorId = "" if err := o.IsValid(); err == nil { t.Fatal("should be invalid") } o.CreatorId = NewId() - if err := o.IsValid(); err == nil { - t.Fatal("should be invalid") + if err := o.IsValid(); err != nil { + t.Fatal(err) } - o.Token = "123" + o.TeamId = "" if err := o.IsValid(); err == nil { t.Fatal("should be invalid") } - o.Token = NewId() + o.TeamId = NewId() + if err := o.IsValid(); err != nil { + t.Fatal(err) + } + + o.Trigger = "" if err := o.IsValid(); err == nil { t.Fatal("should be invalid") } - o.TeamId = "123" + o.Trigger = strings.Repeat("1", 129) if err := o.IsValid(); err == nil { t.Fatal("should be invalid") } - o.TeamId = NewId() + o.Trigger = strings.Repeat("1", 128) + if err := o.IsValid(); err != nil { + t.Fatal(err) + } + + o.URL = "" if err := o.IsValid(); err == nil { t.Fatal("should be invalid") } - o.URL = "nowhere.com/" + o.URL = "1234" if err := o.IsValid(); err == nil { t.Fatal("should be invalid") } - o.URL = "http://nowhere.com/" + o.URL = "https://example.com" + if err := o.IsValid(); err != nil { + t.Fatal(err) + } + + o.Method = "https://example.com" if err := o.IsValid(); err == nil { t.Fatal("should be invalid") } @@ -85,6 +137,11 @@ func TestCommandIsValid(t *testing.T) { t.Fatal(err) } + o.Method = COMMAND_METHOD_POST + if err := o.IsValid(); err != nil { + t.Fatal(err) + } + o.DisplayName = strings.Repeat("1", 65) if err := o.IsValid(); err == nil { t.Fatal("should be invalid") -- cgit v1.2.3-1-g7c22