From 0788cdcadfb5d76b08758f42f01521b45ea76362 Mon Sep 17 00:00:00 2001 From: Jesse Hallam Date: Tue, 31 Jul 2018 16:29:52 -0400 Subject: MM-11420: plugins: compute bundle hash on load (#9172) * plugins: compute bundle hash on load Use this hash to bust client caches whenever the plugin bundle changes. * eliminate redundant pluginHandler * switch to 64-bit FNV-1a * Fix test --- model/manifest_test.go | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) (limited to 'model/manifest_test.go') diff --git a/model/manifest_test.go b/model/manifest_test.go index c6b31e5df..80d22a3ad 100644 --- a/model/manifest_test.go +++ b/model/manifest_test.go @@ -255,6 +255,7 @@ func TestManifestClientManifest(t *testing.T) { }, Webapp: &ManifestWebapp{ BundlePath: "thebundlepath", + BundleHash: []byte{0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15}, }, SettingsSchema: &PluginSettingsSchema{ Header: "theheadertext", @@ -281,10 +282,11 @@ func TestManifestClientManifest(t *testing.T) { sanitized := manifest.ClientManifest() - assert.NotEmpty(t, sanitized.Id) - assert.NotEmpty(t, sanitized.Version) - assert.NotEmpty(t, sanitized.Webapp) - assert.NotEmpty(t, sanitized.SettingsSchema) + assert.Equal(t, manifest.Id, sanitized.Id) + assert.Equal(t, manifest.Version, sanitized.Version) + assert.Equal(t, "/static/theid/theid_000102030405060708090a0b0c0d0e0f_bundle.js", sanitized.Webapp.BundlePath) + assert.Equal(t, manifest.Webapp.BundleHash, sanitized.Webapp.BundleHash) + assert.Equal(t, manifest.SettingsSchema, sanitized.SettingsSchema) assert.Empty(t, sanitized.Name) assert.Empty(t, sanitized.Description) assert.Empty(t, sanitized.Server) -- cgit v1.2.3-1-g7c22