From 3229457de0eb6e04fff6ce4fe1466a828be5f6f6 Mon Sep 17 00:00:00 2001 From: hmhealey Date: Thu, 1 Oct 2015 09:16:25 -0400 Subject: Added model class for user preferences object --- model/preference_test.go | 62 ++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 62 insertions(+) create mode 100644 model/preference_test.go (limited to 'model/preference_test.go') diff --git a/model/preference_test.go b/model/preference_test.go new file mode 100644 index 000000000..8640876a8 --- /dev/null +++ b/model/preference_test.go @@ -0,0 +1,62 @@ +// Copyright (c) 2015 Spinpunch, Inc. All Rights Reserved. +// See License.txt for license information. + +package model + +import ( + "strings" + "testing" +) + +func TestPreferenceIsValid(t *testing.T) { + preference := Preference{} + + if err := preference.IsValid(); err == nil { + t.Fatal() + } + + preference.UserId = NewId() + if err := preference.IsValid(); err == nil { + t.Fatal() + } + + preference.Category = "1234garbage" + if err := preference.IsValid(); err == nil { + t.Fatal() + } + + preference.Category = PREFERENCE_CATEGORY_DIRECT_CHANNELS + if err := preference.IsValid(); err == nil { + t.Fatal() + } + + preference.Name = "1234garbage" + if err := preference.IsValid(); err == nil { + t.Fatal() + } + + preference.Name = PREFERENCE_NAME_SHOWHIDE + if err := preference.IsValid(); err != nil { + t.Fatal() + } + + preference.AltId = "1234garbage" + if err := preference.IsValid(); err == nil { + t.Fatal() + } + + preference.AltId = NewId() + if err := preference.IsValid(); err != nil { + t.Fatal() + } + + preference.Value = "1234garbage" + if err := preference.IsValid(); err != nil { + t.Fatal() + } + + preference.Value = strings.Repeat("01234567890", 20) + if err := preference.IsValid(); err == nil { + t.Fatal() + } +} -- cgit v1.2.3-1-g7c22 From 599644fb2fa75d1760420806c8c821959fc6b645 Mon Sep 17 00:00:00 2001 From: hmhealey Date: Mon, 5 Oct 2015 12:03:27 -0400 Subject: Renamed show_hide preference to show --- model/preference_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'model/preference_test.go') diff --git a/model/preference_test.go b/model/preference_test.go index 8640876a8..bfbe81f39 100644 --- a/model/preference_test.go +++ b/model/preference_test.go @@ -35,7 +35,7 @@ func TestPreferenceIsValid(t *testing.T) { t.Fatal() } - preference.Name = PREFERENCE_NAME_SHOWHIDE + preference.Name = PREFERENCE_NAME_SHOW if err := preference.IsValid(); err != nil { t.Fatal() } -- cgit v1.2.3-1-g7c22 From 2a39e8dbfab8506b09d0d030f87cac4c079b975a Mon Sep 17 00:00:00 2001 From: hmhealey Date: Tue, 13 Oct 2015 11:52:17 -0400 Subject: Removed Preference.AltId --- model/preference_test.go | 29 ++++++++++++++--------------- 1 file changed, 14 insertions(+), 15 deletions(-) (limited to 'model/preference_test.go') diff --git a/model/preference_test.go b/model/preference_test.go index bfbe81f39..170784c1f 100644 --- a/model/preference_test.go +++ b/model/preference_test.go @@ -9,15 +9,19 @@ import ( ) func TestPreferenceIsValid(t *testing.T) { - preference := Preference{} + preference := Preference{ + UserId: "1234garbage", + Category: PREFERENCE_CATEGORY_DIRECT_CHANNEL_SHOW, + Name: PREFERENCE_NAME_TEST, + } if err := preference.IsValid(); err == nil { t.Fatal() } preference.UserId = NewId() - if err := preference.IsValid(); err == nil { - t.Fatal() + if err := preference.IsValid(); err != nil { + t.Fatal(err) } preference.Category = "1234garbage" @@ -25,8 +29,8 @@ func TestPreferenceIsValid(t *testing.T) { t.Fatal() } - preference.Category = PREFERENCE_CATEGORY_DIRECT_CHANNELS - if err := preference.IsValid(); err == nil { + preference.Category = PREFERENCE_CATEGORY_DIRECT_CHANNEL_SHOW + if err := preference.IsValid(); err != nil { t.Fatal() } @@ -35,18 +39,18 @@ func TestPreferenceIsValid(t *testing.T) { t.Fatal() } - preference.Name = PREFERENCE_NAME_SHOW + preference.Name = NewId() if err := preference.IsValid(); err != nil { t.Fatal() } - preference.AltId = "1234garbage" - if err := preference.IsValid(); err == nil { + preference.Name = PREFERENCE_NAME_TEST + if err := preference.IsValid(); err != nil { t.Fatal() } - preference.AltId = NewId() - if err := preference.IsValid(); err != nil { + preference.Value = strings.Repeat("01234567890", 20) + if err := preference.IsValid(); err == nil { t.Fatal() } @@ -54,9 +58,4 @@ func TestPreferenceIsValid(t *testing.T) { if err := preference.IsValid(); err != nil { t.Fatal() } - - preference.Value = strings.Repeat("01234567890", 20) - if err := preference.IsValid(); err == nil { - t.Fatal() - } } -- cgit v1.2.3-1-g7c22 From 97b2f6ffe7fa09a2188163740865322582b00b59 Mon Sep 17 00:00:00 2001 From: hmhealey Date: Tue, 13 Oct 2015 15:18:01 -0400 Subject: Made further changes based on feedback --- model/preference_test.go | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) (limited to 'model/preference_test.go') diff --git a/model/preference_test.go b/model/preference_test.go index 170784c1f..66b7ac50b 100644 --- a/model/preference_test.go +++ b/model/preference_test.go @@ -12,7 +12,7 @@ func TestPreferenceIsValid(t *testing.T) { preference := Preference{ UserId: "1234garbage", Category: PREFERENCE_CATEGORY_DIRECT_CHANNEL_SHOW, - Name: PREFERENCE_NAME_TEST, + Name: NewId(), } if err := preference.IsValid(); err == nil { @@ -24,7 +24,7 @@ func TestPreferenceIsValid(t *testing.T) { t.Fatal(err) } - preference.Category = "1234garbage" + preference.Category = strings.Repeat("01234567890", 20) if err := preference.IsValid(); err == nil { t.Fatal() } @@ -34,7 +34,7 @@ func TestPreferenceIsValid(t *testing.T) { t.Fatal() } - preference.Name = "1234garbage" + preference.Name = strings.Repeat("01234567890", 20) if err := preference.IsValid(); err == nil { t.Fatal() } @@ -44,11 +44,6 @@ func TestPreferenceIsValid(t *testing.T) { t.Fatal() } - preference.Name = PREFERENCE_NAME_TEST - if err := preference.IsValid(); err != nil { - t.Fatal() - } - preference.Value = strings.Repeat("01234567890", 20) if err := preference.IsValid(); err == nil { t.Fatal() -- cgit v1.2.3-1-g7c22