From 6fa7082833812c734aeef8ad24477823ee766f1b Mon Sep 17 00:00:00 2001 From: Saturnino Abril Date: Wed, 26 Apr 2017 23:11:32 +0900 Subject: fix reaction's name validation with + sign in it (#6221) --- model/reaction_test.go | 25 +++++++++++++++---------- 1 file changed, 15 insertions(+), 10 deletions(-) (limited to 'model/reaction_test.go') diff --git a/model/reaction_test.go b/model/reaction_test.go index e447e4329..a35750477 100644 --- a/model/reaction_test.go +++ b/model/reaction_test.go @@ -42,16 +42,6 @@ func TestReactionIsValid(t *testing.T) { } reaction.PostId = NewId() - reaction.EmojiName = "" - if err := reaction.IsValid(); err == nil { - t.Fatal("emoji name should be invalid") - } - - reaction.EmojiName = strings.Repeat("a", 65) - if err := reaction.IsValid(); err == nil { - t.Fatal("emoji name should be invalid") - } - reaction.EmojiName = strings.Repeat("a", 64) if err := reaction.IsValid(); err != nil { t.Fatal(err) @@ -67,11 +57,26 @@ func TestReactionIsValid(t *testing.T) { t.Fatal(err) } + reaction.EmojiName = "+1" + if err := reaction.IsValid(); err != nil { + t.Fatal(err) + } + reaction.EmojiName = "emoji:" if err := reaction.IsValid(); err == nil { t.Fatal(err) } + reaction.EmojiName = "" + if err := reaction.IsValid(); err == nil { + t.Fatal("emoji name should be invalid") + } + + reaction.EmojiName = strings.Repeat("a", 65) + if err := reaction.IsValid(); err == nil { + t.Fatal("emoji name should be invalid") + } + reaction.CreateAt = 0 if err := reaction.IsValid(); err == nil { t.Fatal("create at should be invalid") -- cgit v1.2.3-1-g7c22