From 274b9b6032572dd33b28815a9c13bb18a02becbe Mon Sep 17 00:00:00 2001 From: Corey Hulen Date: Mon, 20 Feb 2017 13:40:32 -0500 Subject: Fixing file info caching issue with Aurora for master (#5477) --- store/sql_file_info_store.go | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) (limited to 'store/sql_file_info_store.go') diff --git a/store/sql_file_info_store.go b/store/sql_file_info_store.go index 467ae39aa..bd0362db0 100644 --- a/store/sql_file_info_store.go +++ b/store/sql_file_info_store.go @@ -143,7 +143,7 @@ func (s SqlFileInfoStore) InvalidateFileInfosForPostCache(postId string) { fileInfoCache.Remove(postId) } -func (fs SqlFileInfoStore) GetForPost(postId string, allowFromCache bool) StoreChannel { +func (fs SqlFileInfoStore) GetForPost(postId string, readFromMaster bool, allowFromCache bool) StoreChannel { storeChannel := make(StoreChannel, 1) go func() { @@ -174,7 +174,13 @@ func (fs SqlFileInfoStore) GetForPost(postId string, allowFromCache bool) StoreC var infos []*model.FileInfo - if _, err := fs.GetReplica().Select(&infos, + dbmap := fs.GetReplica() + + if readFromMaster { + dbmap = fs.GetMaster() + } + + if _, err := dbmap.Select(&infos, `SELECT * FROM @@ -187,7 +193,10 @@ func (fs SqlFileInfoStore) GetForPost(postId string, allowFromCache bool) StoreC result.Err = model.NewLocAppError("SqlFileInfoStore.GetForPost", "store.sql_file_info.get_for_post.app_error", nil, "post_id="+postId+", "+err.Error()) } else { - fileInfoCache.AddWithExpiresInSecs(postId, infos, FILE_INFO_CACHE_SEC) + if len(infos) > 0 { + fileInfoCache.AddWithExpiresInSecs(postId, infos, FILE_INFO_CACHE_SEC) + } + result.Data = infos } -- cgit v1.2.3-1-g7c22