From af275fe9242303581192258ef4f6457fa45a58e4 Mon Sep 17 00:00:00 2001 From: Harshil Sharma Date: Wed, 26 Sep 2018 20:49:22 +0000 Subject: #MM-12130 changes for custom service terms (#9450) * #MM-12130 changes for custom service terms * Fixed styling * Added getServiceTerms API * removed unnecessary panic * removed custom service terms text from flat config * reverted user sql store as those changes are no longer needed * added tests * Updated a config key to be more standard * Added copyright info * Loading service terms only if the feature is enabled * Loading service terms only if the feature is enabled * removed unused index * added createservice termns API * made a param to bool instead of string * added createservice termns API * review fixes * fixed styling * Minor refactoring * removed saveConfig and loadConfig magic * added empty service terms text check to createServiceTerms API * refactoed some urls to be terms_of_service instead of service_terms * removed check for support settings * changed URLs in tests * removed unused code * fixed a bug * added service termd id in conif * fixed a test * review fixes * minor fixes * Fixed TestCreateServiceTerms --- store/storetest/mocks/LayeredStoreDatabaseLayer.go | 16 ++++++ store/storetest/mocks/ServiceTermsStore.go | 62 ++++++++++++++++++++++ store/storetest/mocks/SqlStore.go | 16 ++++++ store/storetest/mocks/Store.go | 16 ++++++ 4 files changed, 110 insertions(+) create mode 100644 store/storetest/mocks/ServiceTermsStore.go (limited to 'store/storetest/mocks') diff --git a/store/storetest/mocks/LayeredStoreDatabaseLayer.go b/store/storetest/mocks/LayeredStoreDatabaseLayer.go index 8e82e9494..7f653fc2f 100644 --- a/store/storetest/mocks/LayeredStoreDatabaseLayer.go +++ b/store/storetest/mocks/LayeredStoreDatabaseLayer.go @@ -729,6 +729,22 @@ func (_m *LayeredStoreDatabaseLayer) SchemeSave(ctx context.Context, scheme *mod return r0 } +// ServiceTerms provides a mock function with given fields: +func (_m *LayeredStoreDatabaseLayer) ServiceTerms() store.ServiceTermsStore { + ret := _m.Called() + + var r0 store.ServiceTermsStore + if rf, ok := ret.Get(0).(func() store.ServiceTermsStore); ok { + r0 = rf() + } else { + if ret.Get(0) != nil { + r0 = ret.Get(0).(store.ServiceTermsStore) + } + } + + return r0 +} + // Session provides a mock function with given fields: func (_m *LayeredStoreDatabaseLayer) Session() store.SessionStore { ret := _m.Called() diff --git a/store/storetest/mocks/ServiceTermsStore.go b/store/storetest/mocks/ServiceTermsStore.go new file mode 100644 index 000000000..9115e6093 --- /dev/null +++ b/store/storetest/mocks/ServiceTermsStore.go @@ -0,0 +1,62 @@ +// Code generated by mockery v1.0.0. DO NOT EDIT. + +// Regenerate this file using `make store-mocks`. + +package mocks + +import mock "github.com/stretchr/testify/mock" +import model "github.com/mattermost/mattermost-server/model" +import store "github.com/mattermost/mattermost-server/store" + +// ServiceTermsStore is an autogenerated mock type for the ServiceTermsStore type +type ServiceTermsStore struct { + mock.Mock +} + +// Get provides a mock function with given fields: id, allowFromCache +func (_m *ServiceTermsStore) Get(id string, allowFromCache bool) store.StoreChannel { + ret := _m.Called(id, allowFromCache) + + var r0 store.StoreChannel + if rf, ok := ret.Get(0).(func(string, bool) store.StoreChannel); ok { + r0 = rf(id, allowFromCache) + } else { + if ret.Get(0) != nil { + r0 = ret.Get(0).(store.StoreChannel) + } + } + + return r0 +} + +// GetLatest provides a mock function with given fields: allowFromCache +func (_m *ServiceTermsStore) GetLatest(allowFromCache bool) store.StoreChannel { + ret := _m.Called(allowFromCache) + + var r0 store.StoreChannel + if rf, ok := ret.Get(0).(func(bool) store.StoreChannel); ok { + r0 = rf(allowFromCache) + } else { + if ret.Get(0) != nil { + r0 = ret.Get(0).(store.StoreChannel) + } + } + + return r0 +} + +// Save provides a mock function with given fields: serviceTerms +func (_m *ServiceTermsStore) Save(serviceTerms *model.ServiceTerms) store.StoreChannel { + ret := _m.Called(serviceTerms) + + var r0 store.StoreChannel + if rf, ok := ret.Get(0).(func(*model.ServiceTerms) store.StoreChannel); ok { + r0 = rf(serviceTerms) + } else { + if ret.Get(0) != nil { + r0 = ret.Get(0).(store.StoreChannel) + } + } + + return r0 +} diff --git a/store/storetest/mocks/SqlStore.go b/store/storetest/mocks/SqlStore.go index 38cdc0a1b..c2852f3a1 100644 --- a/store/storetest/mocks/SqlStore.go +++ b/store/storetest/mocks/SqlStore.go @@ -603,6 +603,22 @@ func (_m *SqlStore) Scheme() store.SchemeStore { return r0 } +// ServiceTerms provides a mock function with given fields: +func (_m *SqlStore) ServiceTerms() store.ServiceTermsStore { + ret := _m.Called() + + var r0 store.ServiceTermsStore + if rf, ok := ret.Get(0).(func() store.ServiceTermsStore); ok { + r0 = rf() + } else { + if ret.Get(0) != nil { + r0 = ret.Get(0).(store.ServiceTermsStore) + } + } + + return r0 +} + // Session provides a mock function with given fields: func (_m *SqlStore) Session() store.SessionStore { ret := _m.Called() diff --git a/store/storetest/mocks/Store.go b/store/storetest/mocks/Store.go index e5d0c4290..8f15650e8 100644 --- a/store/storetest/mocks/Store.go +++ b/store/storetest/mocks/Store.go @@ -320,6 +320,22 @@ func (_m *Store) Scheme() store.SchemeStore { return r0 } +// ServiceTerms provides a mock function with given fields: +func (_m *Store) ServiceTerms() store.ServiceTermsStore { + ret := _m.Called() + + var r0 store.ServiceTermsStore + if rf, ok := ret.Get(0).(func() store.ServiceTermsStore); ok { + r0 = rf() + } else { + if ret.Get(0) != nil { + r0 = ret.Get(0).(store.ServiceTermsStore) + } + } + + return r0 +} + // Session provides a mock function with given fields: func (_m *Store) Session() store.SessionStore { ret := _m.Called() -- cgit v1.2.3-1-g7c22