From 847f30a13b9e784e54455e84069deeeba281874d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jes=C3=BAs=20Espino?= Date: Mon, 24 Sep 2018 15:35:39 +0200 Subject: MM-11707: Change the default setting for EDIT_OTHERS_POSTS (#9447) * MM-11707: Removes edit_others_posts permission from the team_admin role in MakeDefaultRoles(). * MM-11707: Tests fix. * MM-11707: Update test store. * MM-11707: Allow to change the permission for edit the others posts on TE * Fixing tests --- store/storetest/scheme_store.go | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) (limited to 'store') diff --git a/store/storetest/scheme_store.go b/store/storetest/scheme_store.go index a9204fbe2..464af05bb 100644 --- a/store/storetest/scheme_store.go +++ b/store/storetest/scheme_store.go @@ -28,7 +28,6 @@ func createDefaultRoles(t *testing.T, ss store.Store) { Name: model.TEAM_ADMIN_ROLE_ID, DisplayName: model.TEAM_ADMIN_ROLE_ID, Permissions: []string{ - model.PERMISSION_EDIT_OTHERS_POSTS.Id, model.PERMISSION_DELETE_OTHERS_POSTS.Id, }, }) @@ -91,7 +90,7 @@ func testSchemeStoreSave(t *testing.T, ss store.Store) { roleRes1 := <-ss.Role().GetByName(d1.DefaultTeamAdminRole) assert.Nil(t, roleRes1.Err) role1 := roleRes1.Data.(*model.Role) - assert.Equal(t, role1.Permissions, []string{"edit_others_posts", "delete_others_posts"}) + assert.Equal(t, role1.Permissions, []string{"delete_others_posts"}) assert.True(t, role1.SchemeManaged) roleRes2 := <-ss.Role().GetByName(d1.DefaultTeamUserRole) @@ -314,7 +313,7 @@ func testSchemeStoreDelete(t *testing.T, ss store.Store) { roleRes1 := <-ss.Role().GetByName(d1.DefaultTeamAdminRole) assert.Nil(t, roleRes1.Err) role1 := roleRes1.Data.(*model.Role) - assert.Equal(t, role1.Permissions, []string{"edit_others_posts", "delete_others_posts"}) + assert.Equal(t, role1.Permissions, []string{"delete_others_posts"}) assert.True(t, role1.SchemeManaged) roleRes2 := <-ss.Role().GetByName(d1.DefaultTeamUserRole) -- cgit v1.2.3-1-g7c22