From b6d5cc4f696b7438317948710efb860e11c0a1a9 Mon Sep 17 00:00:00 2001 From: Carlos Tadeu Panato Junior Date: Sun, 27 May 2018 15:56:44 +0200 Subject: re-enabling TestSendMailUsingConfigAdvanced (#8836) --- utils/mail.go | 2 +- utils/mail_test.go | 15 ++++++++++----- 2 files changed, 11 insertions(+), 6 deletions(-) (limited to 'utils') diff --git a/utils/mail.go b/utils/mail.go index 119ca0674..651cd376e 100644 --- a/utils/mail.go +++ b/utils/mail.go @@ -229,7 +229,7 @@ func SendMailUsingConfigAdvanced(mimeTo, smtpTo string, from mail.Address, subje } func SendMail(c *smtp.Client, mimeTo, smtpTo string, from mail.Address, subject, htmlBody string, attachments []*model.FileInfo, mimeHeaders map[string]string, fileBackend FileBackend, date time.Time) *model.AppError { - mlog.Debug(fmt.Sprintf("sending mail to %v with subject of '%v'", mimeTo, subject)) + mlog.Debug(fmt.Sprintf("sending mail to %v with subject of '%v'", smtpTo, subject)) htmlMessage := "\r\n" + htmlBody + "" diff --git a/utils/mail_test.go b/utils/mail_test.go index 22a50df5f..4cb2d7594 100644 --- a/utils/mail_test.go +++ b/utils/mail_test.go @@ -4,11 +4,16 @@ package utils import ( + "bytes" + "fmt" "strings" "testing" + "net/mail" "net/smtp" + "github.com/mattermost/mattermost-server/model" + "github.com/stretchr/testify/assert" "github.com/stretchr/testify/require" ) @@ -127,8 +132,8 @@ func TestSendMailUsingConfig(t *testing.T) { } } -/*func TestSendMailUsingConfigAdvanced(t *testing.T) { - cfg, _, err := LoadConfig("config.json") +func TestSendMailUsingConfigAdvanced(t *testing.T) { + cfg, _, _, err := LoadConfig("config.json") require.Nil(t, err) T = GetUserTranslations("en") @@ -150,9 +155,9 @@ func TestSendMailUsingConfig(t *testing.T) { filePath2 := fmt.Sprintf("test2/%s", fileName) fileContents1 := []byte("hello world") fileContents2 := []byte("foo bar") - _, err := fileBackend.WriteFile(bytes.NewReader(fileContents1), filePath1) + _, err = fileBackend.WriteFile(bytes.NewReader(fileContents1), filePath1) assert.Nil(t, err) - _, err := fileBackend.WriteFile(bytes.NewReader(fileContents2), filePath2) + _, err = fileBackend.WriteFile(bytes.NewReader(fileContents2), filePath2) assert.Nil(t, err) defer fileBackend.RemoveFile(filePath1) defer fileBackend.RemoveFile(filePath2) @@ -221,7 +226,7 @@ func TestSendMailUsingConfig(t *testing.T) { } } } -}*/ +} func TestAuthMethods(t *testing.T) { auth := &authChooser{ -- cgit v1.2.3-1-g7c22