From c737723a0496e9fd8b236caebf56316564764480 Mon Sep 17 00:00:00 2001 From: Girish S Date: Mon, 2 Nov 2015 09:56:12 +0530 Subject: Show error message when team name is fewer than 4 characters I have still kept the length validation in team_signup_url_page.jsx in case user chooses the url shorter than 4 characters --- web/react/components/team_signup_display_name_page.jsx | 3 +++ 1 file changed, 3 insertions(+) (limited to 'web') diff --git a/web/react/components/team_signup_display_name_page.jsx b/web/react/components/team_signup_display_name_page.jsx index 4d08274e4..5356bf8a9 100644 --- a/web/react/components/team_signup_display_name_page.jsx +++ b/web/react/components/team_signup_display_name_page.jsx @@ -25,6 +25,9 @@ export default class TeamSignupDisplayNamePage extends React.Component { if (!displayName) { this.setState({nameError: 'This field is required'}); return; + } else if (displayName.length <= 2 || displayName.length > 15) { + this.setState({nameError: 'Name must be 3 or more characters up to a maximum of 15'}); + return; } this.props.state.wizard = 'team_url'; -- cgit v1.2.3-1-g7c22 From 538ccc90bd59c77d640329c96001bdc8c38c0081 Mon Sep 17 00:00:00 2001 From: Girish S Date: Mon, 2 Nov 2015 13:14:02 +0530 Subject: Update the UI to check for 4 characters to match the server fixes PLT-692 --- web/react/components/team_signup_display_name_page.jsx | 4 ++-- web/react/components/team_signup_url_page.jsx | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) (limited to 'web') diff --git a/web/react/components/team_signup_display_name_page.jsx b/web/react/components/team_signup_display_name_page.jsx index 5356bf8a9..2005ecc31 100644 --- a/web/react/components/team_signup_display_name_page.jsx +++ b/web/react/components/team_signup_display_name_page.jsx @@ -25,8 +25,8 @@ export default class TeamSignupDisplayNamePage extends React.Component { if (!displayName) { this.setState({nameError: 'This field is required'}); return; - } else if (displayName.length <= 2 || displayName.length > 15) { - this.setState({nameError: 'Name must be 3 or more characters up to a maximum of 15'}); + } else if (displayName.length < 4 || displayName.length > 15) { + this.setState({nameError: 'Name must be 4 or more characters up to a maximum of 15'}); return; } diff --git a/web/react/components/team_signup_url_page.jsx b/web/react/components/team_signup_url_page.jsx index 02d5cab8e..8972fda1a 100644 --- a/web/react/components/team_signup_url_page.jsx +++ b/web/react/components/team_signup_url_page.jsx @@ -35,8 +35,8 @@ export default class TeamSignupUrlPage extends React.Component { if (cleanedName !== name || !urlRegex.test(name)) { this.setState({nameError: "Use only lower case letters, numbers and dashes. Must start with a letter and can't end in a dash."}); return; - } else if (cleanedName.length <= 2 || cleanedName.length > 15) { - this.setState({nameError: 'Name must be 3 or more characters up to a maximum of 15'}); + } else if (cleanedName.length < 4 || cleanedName.length > 15) { + this.setState({nameError: 'Name must be 4 or more characters up to a maximum of 15'}); return; } -- cgit v1.2.3-1-g7c22