From b023b891550cd8fb2f874e822f05921d13f51fb2 Mon Sep 17 00:00:00 2001 From: David Meza Date: Tue, 1 Aug 2017 07:12:25 -0500 Subject: Use Constants.MAX_CHANNELNAME_LENGTH where a fixed number like 22 or 64 is used for max length of channel names. (#7041) --- webapp/components/rename_channel_modal.jsx | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) (limited to 'webapp/components/rename_channel_modal.jsx') diff --git a/webapp/components/rename_channel_modal.jsx b/webapp/components/rename_channel_modal.jsx index d4cddb9db..8d36e15c7 100644 --- a/webapp/components/rename_channel_modal.jsx +++ b/webapp/components/rename_channel_modal.jsx @@ -21,7 +21,7 @@ const holders = defineMessages({ }, maxLength: { id: 'rename_channel.maxLength', - defaultMessage: 'This field must be less than 22 characters' + defaultMessage: 'This field must be less than {maxLength, number} characters' }, lowercase: { id: 'rename_channel.lowercase', @@ -136,8 +136,8 @@ export class RenameChannelModal extends React.Component { if (!channel.display_name) { state.displayNameError = formatMessage(holders.required); state.invalid = true; - } else if (channel.display_name.length > 22) { - state.displayNameError = formatMessage(holders.maxLength); + } else if (channel.display_name.length > Constants.MAX_CHANNELNAME_LENGTH) { + state.displayNameError = formatMessage(holders.maxLength, {maxLength: Constants.MAX_CHANNELNAME_LENGTH}); state.invalid = true; } else { state.displayNameError = ''; @@ -147,8 +147,8 @@ export class RenameChannelModal extends React.Component { if (!channel.name) { state.nameError = formatMessage(holders.required); state.invalid = true; - } else if (channel.name.length > 22) { - state.nameError = formatMessage(holders.maxLength); + } else if (channel.name.length > Constants.MAX_CHANNELNAME_LENGTH) { + state.nameError = formatMessage(holders.maxLength, {maxLength: Constants.MAX_CHANNELNAME_LENGTH}); state.invalid = true; } else { const cleanedName = cleanUpUrlable(channel.name); @@ -264,7 +264,7 @@ export class RenameChannelModal extends React.Component { className='form-control' placeholder={formatMessage(holders.displayNameHolder)} value={this.state.displayName} - maxLength='64' + maxLength={Constants.MAX_CHANNELNAME_LENGTH} /> {displayNameError} @@ -287,7 +287,7 @@ export class RenameChannelModal extends React.Component { ref='channelName' placeholder={formatMessage(holders.handleHolder)} value={this.state.channelName} - maxLength='64' + maxLength={Constants.MAX_CHANNELNAME_LENGTH} readOnly={readOnlyHandleInput} /> -- cgit v1.2.3-1-g7c22